Package Base Details: arc-gtk-theme-git

Git Clone URL: https://aur.archlinux.org/arc-gtk-theme-git.git (read-only)
Submitter: NicoHood
Maintainer: NicoHood
Last Packager: NicoHood
Votes: 229
Popularity: 0.053365
First Submitted: 2018-03-25 19:17
Last Updated: 2018-07-31 14:42

Latest Comments

« First ‹ Previous ... 4 5 6 7 8 9

ebilgenius commented on 2015-05-21 17:58

@edh

Thank you for your suggestions! As is probably very obvious I'm new to Arch and the AUR so some guidance is always welcome. I've implemented your suggestions into a new package and am waiting for this one to be merged:

https://aur.archlinux.org/packages/gtk-theme-arc-git/

Let me know if you have any more suggestions or guidance!

edh commented on 2015-05-21 16:02

Dear ebilgenius,
nice to see someone who adds a theme to the AUR, however you made some rookie mistakes:
- bash can be assumed to be on the system since the AUR should only be used if base and base-devel package-group are both installed therefore it is bad practise to add them eitherway
- you package has no source although git is supported by makepkg
- the pkgver should be related to the repo, e.g. the number of commits to one branch plus the last shortened hash of the previous commit
- do not simply use "cp -r" instead prefer "cp -dpr --no-preserve=ownership"
- subjective, me nagging: avoid using find
- subjective, me nagging: indicate what your package is in the package name: e.g. call the package gtk-theme-arc-git

It was not my intention to insult you, therefore I tried to rewrite the PKGBUILD to show my esteem:
# Maintainer: zach <zach {at} zach-adams {dot} com>
# Contributor: Gordian Edenhofer <gordian.edenhofer[at]yahoo[dot]de

pkgname=gtk-theme-arc-git
_pkgname=Arc
pkgver=22.f4c0094
pkgrel=1
pkgdesc="A flat theme with transparent elements for GTK 3, GTK 2 and Gnome-Shell."
arch=('any')
url="https://github.com/horst3180/Arc-theme"
license=('GPL3')
depends=('gtk3')
makedepends=('git')
source=(${_pkgname}::'git+https://github.com/horst3180/Arc-theme.git')
sha256sums=('SKIP')

pkgver() {
cd "${srcdir}/${_pkgname}"
echo $(git rev-list --count HEAD).$(git rev-parse --short HEAD)
}

package() {
cd "${srcdir}/${_pkgname}"
install -dm755 "${pkgdir}/usr/share/themes/${_pkgname}"
rm -rf {.git,COPYING,README.md}
cp -dpr --no-preserve=ownership . "${pkgdir}/usr/share/themes/${_pkgname}/"
}