Package Details: zettlr 1.6.0-2

Git Clone URL: https://aur.archlinux.org/zettlr.git (read-only, click to copy)
Package Base: zettlr
Description: A markdown editor for writing academic texts and taking notes
Upstream URL: https://www.zettlr.com
Licenses: GPL
Submitter: BrLi
Maintainer: BrLi
Last Packager: BrLi
Votes: 4
Popularity: 0.65
First Submitted: 2019-06-17 04:47
Last Updated: 2020-03-08 02:20

Dependencies (8)

Required by (0)

Sources (1)

Pinned Comments

kseistrup commented on 2019-09-07 12:49

The note about $NODE_ENV is still valid: If $NODE_ENV is set to production, building the package fails.

Latest Comments

1 2 Next › Last »

eschwartz commented on 2020-03-12 14:14

@BrLi,

1) The advantage of git over tarballs is that when building the same package again and again, each update is fairly small. The disadvantage is that an uncached download over git is 84M and with a tarball it is 30M. I'm not going to claim either one is fundamentally better, though. Note you can still use checksumming over git, by pinning to a #commit= instead of a tag, and manually updating the commit as well as the pkgver every time a new release comes out. checksumming can provide TOFU as well.

2) shellcheck is indeed lossy, but the srcdir and pkgdir variables, at least, must be quoted as they can and will contain spaces. $pkgname and $pkgver do not need to be quoted, since they cannot contain spaces (and makepkg will immediately abort with a fatal error if they do).

It's strange that before you fixed the quoting, you had quoted "$px"x"$px".png which does not need quoting since they are hardcoded integers without spaces, and failed to quote the $srcdir variable... I'd actually recommend removing the quotes on "$px" and "$pkgname" there since the more you enter and leave a quoting context, the harder it becomes to read. Either quote the entire string, or only quote the "$srcdir"/ part, either one is valid shell and equally readable.

BrLi commented on 2020-03-08 02:01

Hi, @caleb, thanks for the input.

I'd explain some below why I'm writting script in this way:

  1. the git source instead of tarball: it isn't unstable just because I'm fetching source from git, there are plenty of packages in official repos doing so, so I see it fine. And tbh, even using tarball, I'm just updpkgsums on every version pump, which is equivalently insecure to not check sum. btw git source is a better way when dealing with remote CI packaging.

  2. the quoting, well...it is...well...let me just say that the PKGBUILD can be really lossy, I could certainly update it to a way that passes shellcheck, but who cares?

  3. the usage of /dev/stdin <<: this is used in official firefox packages, and I find it brilliant as it stuff infos in whole one PKGBUILD instead of where ppl have to look around to gather what is changed by go through all the source files included in git tree.

  4. gendesk and node-prune: the concept is to avoid too many out of official repo dependencies when it comes to AUR package, especially when they are not runtime requirements, thus, I might add node-prune as it sees its seat in [community] but not now. gendesk on the other hand, is not handy I must say, I've tried it for a few times, but the outcome is less pleasant than manually written desktop file.

  5. thanks for the catch up of 512 px icon. Besides, since it is the same as logo, I see no reason to include another file to /usr/share/pixmaps, as the org.freedesktop standards work with icons under /usr/share/icons/ directly.

  6. the sed lines: it is just a matter of taste.

caleb commented on 2020-03-07 08:55

@BrLi I've done a major overhaul of the PKGBUILD to address a number of issues including packaging things you missed that are new in 1.6.0, but also fixing the issue with the source, a lot of shell quoting issues, etc. You can see the result in my fork here. Please at least add that as a remote and then cherry pick this commit into your branch. You can also add me as a co-maintainer and I'll push it directly and help keep this updated.

caleb commented on 2020-03-07 06:54

Please build this from a tar archive rather than a git tag, this is not a -git package and should have a checksumed download.

I can help fix this up if you add me as a co-maintainer.

kseistrup commented on 2019-12-21 20:57

Same shit, @BrLi: If NODE_ENV is set to production, building the package fails.

But if I

$ env NODE_ENV= makepkg -s

everything's fine.

BrLi commented on 2019-12-21 14:09

@kseistrup: can you check that if it is still an issue to have NODE_ENV set?

kseistrup commented on 2019-09-07 12:49

The note about $NODE_ENV is still valid: If $NODE_ENV is set to production, building the package fails.

BrLi commented on 2019-09-06 19:45

The install process of nodejs/yarn/electron application is too sequential that it is almost imposible to skip the electron compiling part, if you have any good idea, please don't hesitate to leave a message and let me know.

werod commented on 2019-06-25 05:11

@BrLi Works like a charm for me now. Thank you!

BrLi commented on 2019-06-25 03:30

Ok, the problem is due to webhostinghub-glyphs font in AUR has rename the fontname which is unknown to upstream nor zettlr.

I've update the PKGBUILD of the font to include the original font which should fix the issue.