Arch Linux User Repository

Thanks for the remark, issue is fixed.

FYI: Upstream build behavior has changed to not generate translation files when building default target.

The package fails to build with this message:

-- Installing: /home/guraltsev/.cache/pikaur/build/xournalpp-git/pkg/xournalpp-git/usr/share/metainfo/com.github.xournalpp.xournalpp.appdata.xml
CMake Error at po/cmake_install.cmake:41 (file):
  file INSTALL cannot find
  "/home/guraltsev/.cache/pikaur/build/xournalpp-git/src/xournalpp/build/po/cs.gmo".
Call Stack (most recent call first):
  cmake_install.cmake:102 (include)

Unfortunately I am at loss as to how to fix this. The various language localizations (po) seem to be there, however there is something wrong in the build process.

@youduda: Thanks for the update. The problem was that yay -Syu always wanted to rebuild the package, every time I ran it. Anyway, all good now again.

The issue here was that they "released" a nighly version, but the last tag follows the usual naming scheme again. Btw, if in the future someone breaks with the tag name scheme again, just use pacman -S xournalpp-git to enforce the update.

The pkgver function needs updating, I think. git describe --long --tags gives nightly-248-g6fcd7150 now, which leads to a package version, that always seems out-of-date.

@youduda. hmm, that's strange. I've just commented out lua detection in CMakeLists.txt, so Lua_FOUND is not true and ENABLE_PLUGINS is not true. After such build everything works properly, Xournalpp doesn't try to load lua libs (checked by strace -T -e trace=openat ./xournalpp) and Xournalpp doesn't have Plugin menu section.

Moving lua to optional dependencies breaks plugin support when building in clean environment. For this Xournalpp must support only loading lua libraries when lua is installed.

One more, you don't need gettext in makedepends.

See wiki page:

Note: The group base-devel is assumed to be already installed when building with makepkg. Members of this group should not be included in makedepends array.

$ pacman -Qi gettext | grep Groups
Groups          : base  base-devel

And move lua to optdepends():

optdepends=('lua>=5.3: Enable Xournal++ Plugins')

And could you please add check() stage:

-makedepends=('git' 'cmake' 'gettext')
+makedepends=('git' 'cmake' 'gettext' 'cppunit>=1.12')
...
-       cmake -DCMAKE_INSTALL_PREFIX="/usr/" -DDEV_CONFIG_DIR="$configdir/xournalpp" ..
-       make
+       cmake -DCMAKE_INSTALL_PREFIX="/usr/" -DDEV_CONFIG_DIR="$configdir/xournalpp" -DENABLE_CPPUNIT=ON ..
+       cmake --build .
...
+check() {
+       cd "${srcdir}/${_pkgname}/build"
+
+       cmake --build . --target test
+}

Minor fix ('r' before number of commits, ref. pkgver):

$ git describe --tags | sed -e 's|v||g' -e 's|glib.||g' -e 's|-|.|g'
1.0.13.nightly.20190709.86.g02084518
$ git describe --long --tags | sed 's/\([^-]*-g\)/r\1/;s/-/./g'
1.0.13.nightly.20190709.r86.g02084518