Package Details: xfce4-sysinfo 152.0.1-2

Git Clone URL: https://aur.archlinux.org/xfce4-sysinfo.git (read-only, click to copy)
Package Base: xfce4-sysinfo
Description: A tool to show systeminformation in xfce
Upstream URL: https://github.com/lxgr-linux/xfce4-sysinfo
Keywords: xfce4
Licenses: GPL3
Submitter: lxgr
Maintainer: lxgr
Last Packager: lxgr
Votes: 1
Popularity: 0.032578
First Submitted: 2020-04-23 22:37
Last Updated: 2020-08-12 15:27

Latest Comments

lxgr commented on 2020-08-12 15:34

changed it, same as buildaur.

diabonas commented on 2020-08-12 14:44

Same thing as for buildaur: please provide checksums and remove the superfluous makedepends on git, looks good otherwise :)

lxgr commented on 2020-08-12 11:53

done

lxgr commented on 2020-08-12 11:04

changed this in buildaur, gonna do it here later

diabonas commented on 2020-08-12 07:21

The PKGBUILD is still not in a great shape:

  • Why are you using a fixed version number in pkgver in combination with a varying $commit variable? If you update $commit, the version number is not going to get updated. Please keep the pkgver() function you had, and just use something like source=("git+$url.git#commit=4b855d608f0948b40af94581330d602a04927640"). Even better, since you appear to be the maintainer of the upstream repository, just tag a release and use that to build from.
  • license=('GPL v3') is not a valid license.
  • Why are you commenting out pkgver() and prepare() instead of removing them completely? The AUR keeps a history of all Git commits anyway, no need to preserve stuff in the PKGBUILD that is not used any more.
  • Please use meaningful commit messages instead of things like "---", "ll", " useful commit message", ...

Please have a look at the Arch package guidelines, the PKGBUILD ArchWiki page and the VCS package guidelines.

lxgr commented on 2020-08-10 21:06

Done

haawda commented on 2020-06-30 23:55

Please stick to a specific commit of the github repo or let a TU rename this to xfce4-sysinfo-git.