@Fedi265 @chron: Thanks for all the discussion, I have pushed an update to have options=(debug) now.
Search Criteria
Package Details: wlroots-git 0.9.1.r7.g6d3f3b93-2
| Git Clone URL: | https://aur.archlinux.org/wlroots-git.git (read-only, click to copy) |
|---|---|
| Package Base: | wlroots-git |
| Description: | Modular Wayland compositor library |
| Upstream URL: | https://github.com/swaywm/wlroots |
| Keywords: | compositor library wayland |
| Licenses: | |
| Conflicts: | |
| Provides: | |
| Submitter: | aperez |
| Maintainer: | aperez |
| Last Packager: | aperez |
| Votes: | 35 |
| Popularity: | 0.30 |
| First Submitted: | 2018-02-20 16:48 |
| Last Updated: | 2020-01-16 08:09 |
Dependencies (15)
- libcap (libcap-git)
- libinput (libinput-swap-two-and-three-finger-tap, libinput-fix101796-git, libinput-no-hysteresis, libinput-git, libinput-nosmoothing, libinput-nomiddletap, libinput-multiplier)
- libxcb (libxcb-git)
- libxkbcommon (libxkbcommon-git)
- opengl-driver (dummy-opengl-driver-git, mesa-grate-git, mesa-hybris, mesa-noglvnd, nvidia-410xx-utils, mesa-aco-git, swiftshader-git, mesa-arm-git, nvidia-utils-full-beta-all, nvidia-utils-full-beta, nvidia-utils-beta, mesa-git, nvidia-390xx-utils, nvidia-vulkan-utils, mesa, nvidia-utils)
- pixman (pixman-git)
- systemd (eudev-git, systemd-cdown-git, systemd-git, systemd-light, systemd-selinux)
- wayland (wayland-git)
- xcb-util-errors
- xcb-util-wm
- git (git-git) (make)
- meson (meson-git) (make)
- ninja (ninja-git, ninja-kitware, ninja-samurai, ninja-mem) (make)
- wayland-protocols (wayland-protocols-git) (make)
- xorgproto (xorgproto-git) (make)
Required by (22)
- bspwc-git (requires wlroots)
- cage-git
- golang-github-swaywm-go-wlroots (requires wlroots)
- hikari (requires wlroots)
- kanshi-git (requires wlroots)
- kiwmi-git (requires wlroots)
- phoc (requires wlroots)
- phoc-git (requires wlroots)
- sway-git
- sway-xdg-shell-v6-git
- sway9 (requires wlroots)
- way-cooler-git (requires wlroots)
- waybox (requires wlroots)
- wayfire (requires wlroots)
- wayfire-desktop-git
- wayfire-git (requires wlroots)
- wayfire-plugins-extra-git (requires wlroots)
- wf-config-git (requires wlroots) (make)
- wlr-brightness-git (requires wlroots)
- wlrobs-hg (requires wlroots)
- wltrunk-git (requires wlroots)
- xdg-desktop-portal-wlr-git (requires wlroots)
Sources (1)
aperez commented on 2020-01-16 08:12
Ferdi265 commented on 2020-01-15 14:15
(bump to enable notifications for me since I forgot in the last comment)
Ferdi265 commented on 2020-01-15 14:15
@aperez: I don't particularly care wether debug is part of wlroot's options array; it's just that overriding strip to off breaks the debug info in the package for people who clean their source directories after building.
@chron: I can understand why options=(debug) would make sense. You might want a development package like wlroots-git to be built with debug info even if other packages on the system aren't, in order to get more useful bug reports by people using wlroots-git.
TL;DR:
for me, options=(debug) or options=() would be acceptable. It's just the !strip that's bothering me.
options=(debug strip) would probably offend people who don't like the -debug extra packages for some reason. (e.g. tooling support is lacking; yay doesn't install -debug packages generated by makepkg by default)
chron commented on 2020-01-14 20:55
@aperez: No, I think he ment you should use debug and strip or remove options=() entirely/leave it empty.
I think you shouldn't overwrite a users /etc/makepkg.conf defaults, if they need either !strip or debug they can add the options themself.
aperez commented on 2020-01-14 12:35
@Ferdi265: So what you would suggest? If I understand your reasoning correctly, you would like to have options=(debug) in the PKGBUILD, so each user can decide choose to use strip or !strip. Isn't it?
aperez commented on 2020-01-14 12:33
FreeDRP and related dependencies have now been removed, thanks @Mel for the heads up!
Mel commented on 2020-01-13 19:13
freerdp can probably be removed from the depends array. see: https://github.com/swaywm/wlroots/commit/ebdbe177d62d3c8bab04f77b86326804ff185bef
Ferdi265 commented on 2020-01-09 17:32
Is there any reason why the PKGBUILD overrides the strip option to off?
Having both debug and strip activated produces a separate debug package that will be installed to /usr/src/debug and /usr/lib/debug.
Having debug and !strip activated produces a single packages with binaries containing debug info, which reference the build folder however.
Many AUR helpers clean the build directory after packaging, which removes the sources, making the debug infos often less useful in case of a crash.
If the strip option is not overridden to off, users are able to choose on their own, whether they want a separate debug package or not.
Mel commented on 2019-12-21 11:46
@habarnam is correct. It should definitely be added to makedepends here.
habarnam commented on 2019-12-21 09:35
I think this package now needs "xorgproto" as a build dependency.
Before installing xorgproto I was reciving a build error saying xcb lib can't be found.
Pinned Comments
aperez commented on 2018-09-28 08:31
IMPORTANT
Please do not flag this package as out-of-date if the only change you need is to update to a newer version. It is not needed because it always fetches the sources using Git and uses the most recent version without needing to modify the PKGBUILD — just rebuild the package.
Also, please try building in a clean chroot before assuming that the PKGBUILD is broken.