Package Details: virtualfish 2.5.1-1

Git Clone URL: https://aur.archlinux.org/virtualfish.git (read-only, click to copy)
Package Base: virtualfish
Description: Fish shell tool for managing Python virtual environments
Upstream URL: https://github.com/justinmayer/virtualfish
Keywords: environment fish python virtual
Licenses: MIT
Submitter: XenGi
Maintainer: XenGi
Last Packager: XenGi
Votes: 6
Popularity: 0.26
First Submitted: 2017-09-24 15:17
Last Updated: 2020-12-06 20:33

Latest Comments

1 2 3 Next › Last »

XenGi commented on 2020-11-27 12:34

Ah OK. I didn't connect these two issues. Sure the version requirement could just be removed. I'll probably do that anyway but it would be nicer to understand how epochs work and do this "properly".

ruahcra commented on 2020-11-27 12:07

It's the version check that is failing to handle the epoch so putting it in package() still ends up with the same problem. Since the program itself still runs and gracefully exits with a user friendly error message when not running in fish or with fish < 3.1 (https://github.com/justinmayer/virtualfish/blob/1764c07829ffe8bdf11396ff5009ca5f4198b24a/virtualfish/loader/cli.py#L37), I think it's OK to leave out the version requirement if there's no other way around the issue with the version check for fish-git. Also another thing to consider, isn't it more likely someone has fish-git installed rather than fish < 3.1 which is will soon be more one year old? Anyway I'm content with using the virtualfish-git package for now. I would rather like to find out the proper way to handle the epoch situation in the first place - we just need someone more knowledgeable to show us the way.

XenGi commented on 2020-11-27 10:11

I'm still not sure what the use-case for virtualfish without fish would be, so I just tried using it in bash with this result.

bash $ vf
VirtualFish isn't compatible with bash, only Fish 3.1.0+.

The upstream author also says that it requires fish>=3.1 to work, so I will keep the fish dependency in the package until someone comes up with a convincing reason to remove it.

What I did is moving fish to a runtime dependency. Because what @ruahcra said is true. The package doesn't need fish to build, it only needs it to run. I hope this solves your problem.

ruahcra commented on 2020-11-26 13:21

I ended up just making virtualfish-git and removed the fish dependency check in its PKGBUILD

ruahcra commented on 2020-11-06 15:03

Since fish isn't needed to build this package then you can just remove the check:

https://wiki.archlinux.org/index.php/PKGBUILD#depends An array of packages that must be installed for the software to build and run.

ruahcra commented on 2020-10-12 13:18

I think their use of epoch is mistaken. Looks like it has had it ever since the first commit of their PKGBUILD, but their use doesn't appear to be valid according to https://wiki.archlinux.org/index.php/PKGBUILD#epoch

EDIT: Actually I guess it is (or was) valid since the versioning scheme appears to have changed in 2012, but I wonder if it can be removed now...

XenGi commented on 2020-10-12 12:42

fish-git seems to have an epoch in the version. I have no idea how to handle this. :( I'll try to find out later today after work.

ruahcra commented on 2020-10-12 12:31

Somehow fish>=3.1 isn't playing nicely with fish-git:

>git clone ssh://aur@aur.archlinux.org/virtualfish.git
>cd virtualfish/                                                
>makepkg PKGBUILD
==> Making package: virtualfish 2.5.0-1
==> Checking runtime dependencies...
==> Missing dependencies:
  -> fish>=3.1
==> Checking buildtime dependencies...
==> ERROR: Could not resolve all dependencies.
>pacman -Qo fish
/usr/bin/fish is owned by fish-git 2:3.1.2.r1526.gf73ee3011-1

elanglois commented on 2020-04-07 21:21

Removing the xdg dependency seems sensible to me. If you want to be fully compliant with the XDG spec, the replacement line would be

INSTALL_DIR = os.path.join(os.getenv('XDG_CONFIG_HOME', os.path.expanduser('~/.config')), 'fish', 'conf.d')

XenGi commented on 2020-04-07 13:37

I completely removed the damn package now. It's useless anyway. it basically installs and imports a package just to get a path that is fixed anyway. Feels like the javascript debacle all over again. Should work now.