Package Details: slack-libpurple-git r200.be97802-1

Git Clone URL: https://aur.archlinux.org/slack-libpurple-git.git (read-only, click to copy)
Package Base: slack-libpurple-git
Description: A purple-based (Pidgin) plugin for Slack.
Upstream URL: https://github.com/dylex/slack-libpurple.git
Licenses: GPL3
Submitter: sergej
Maintainer: vasya
Last Packager: vasya
Votes: 16
Popularity: 0.022886
First Submitted: 2017-08-11 17:01
Last Updated: 2020-01-21 18:13

Latest Comments

vasya commented on 2020-01-21 18:12

@CyberShadow, understood now. The patch still changes the code, but the change itself is meaningless now. Removed the patch and pushed the new (cleaner) version (along with version dump). Thanks!

CyberShadow commented on 2020-01-21 17:57

Probably it was sent upstream at the same time as added to this package. Now that upstream applied it, it's no longer needed here. Thanks!

vasya commented on 2020-01-21 17:56

Hi. The package was disowned by sergej right now, and I've just adopted it. If you have any improvement ideas, please share.

Does anybody know why we had the "patch" in the first place, what does it do?

CyberShadow commented on 2018-11-08 15:22

@vasya Your proposed "patch" is almost exactly what's already in the current code:

https://github.com/dylex/slack-libpurple/blob/master/slack.c#L128-L131

api-token-in-passwd.patch is currently completely unnecessary. @sergej should have removed it in commit 437d7a03a9ba instead of "updating" it.

vasya commented on 2018-11-08 13:44

I wonder, can the patch be reduced to?: + if (!token || !*token) { + token = purple_account_get_password(account); + } One indentation less than currently, placed before the current already-existing "if".

CyberShadow commented on 2018-07-22 02:46

Why is api-token-in-passwd.patch needed? There is code which does exactly what the patch adds directly above the added code. In fact, you can even see the purple_account_get_password in the original code in the patch's context.

PhotonX commented on 2018-05-31 10:39

Current version fails to build with https://pastebin.com/smCB6iwL

andreyv commented on 2018-05-04 07:22

Why is options=(!strip) needed? A comment in the PKGBUILD would be useful.

morningpee commented on 2018-04-09 18:05

Commit 81b330930f broke api-token-in-passwd.patch, flagging as out-of-date.

kurnevsky commented on 2017-09-14 07:47

It's possible to use make install now, so please replace package step with (it also installs icons):

package() {
cd "$srcdir/$pkgname"
make DESTDIR="$pkgdir" install
}