Arch Linux User Repository

@gugah @onekopaka Thanks! I've pushed a fix for the compilation error.

I was able to get things building by adapting a change that was made to SimGear in its repo https://github.com/FlightGear/simgear/commit/39d616a0d591d9df6e3cab947952e140986952e6 though I ignored the style changes of the declaration to minimize the size of the diff.

Here's the diff to apply to the source:

diff --color --unified --recursive --text simgear-2020.3.4.orig/simgear/props/props.cxx simgear-2020.3.4.new/simgear/props/props.cxx
--- simgear-2020.3.4.orig/simgear/props/props.cxx       2020-12-21 20:57:57.338327502 -0800
+++ simgear-2020.3.4.new/simgear/props/props.cxx        2020-12-21 20:58:37.398237351 -0800
@@ -574,11 +574,8 @@
            int last_index = -1)
 {
   using namespace boost;
-  typedef split_iterator<typename range_result_iterator<Range>::type>
-    PathSplitIterator;

-  PathSplitIterator itr
-    = make_split_iterator(path, first_finder("/", is_equal()));
+  auto itr = make_split_iterator(path, first_finder("/", is_equal()));
   if (*path.begin() == '/')
     return find_node_aux(current->getRootNode(), itr, create, last_index);
    else

I'm getting the following error when compiling simgear 2020.3.4-1 (using up-to-date dependencies)

[ 41%] Building CXX object simgear/CMakeFiles/SimGearCore.dir/props/propertyObject.cxx.o
[ 42%] Building CXX object simgear/CMakeFiles/SimGearCore.dir/props/props.cxx.o
/tmp/yay-tmp/aur-simgear/src/simgear-2020.3.4/simgear/props/props.cxx: In function ‘SGPropertyNode* find_node(SGPropertyNode*, const Range&, bool, int)’:
/tmp/yay-tmp/aur-simgear/src/simgear-2020.3.4/simgear/props/props.cxx:577:69: error: template argument 1 is invalid
  577 |   typedef split_iterator<typename range_result_iterator<Range>::type>
      |                                                                     ^
/tmp/yay-tmp/aur-simgear/src/simgear-2020.3.4/simgear/props/props.cxx: In instantiation of ‘SGPropertyNode* find_node(SGPropertyNode*, const Range&, bool, int) [with Range = boost::iterator_range<const char*>]’:
/tmp/yay-tmp/aur-simgear/src/simgear-2020.3.4/simgear/props/props.cxx:2113:26:   required from here
/tmp/yay-tmp/aur-simgear/src/simgear-2020.3.4/simgear/props/props.cxx:581:26: error: cannot convert ‘boost::algorithm::split_iterator<const char*>’ to ‘PathSplitIterator’ {aka ‘int’} in initialization
  581 |     = make_split_iterator(path, first_finder("/", is_equal()));
      |       ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                          |
      |                          boost::algorithm::split_iterator<const char*>
make[2]: *** [simgear/CMakeFiles/SimGearCore.dir/build.make:1720: simgear/CMakeFiles/SimGearCore.dir/props/props.cxx.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1025: simgear/CMakeFiles/SimGearCore.dir/all] Error 2
make: *** [Makefile:171: all] Error 2

I have tried the "-fpermissive" option to -DCMAKE_CXX_FLAGS in PKGBUILD for cmake with no luck.

Interesting, I'm not seeing this problem locally. Will investigate, thanks for the report!

Another workaround for the "include" bug :

Create a symbolic link "/include" on your system:

ln -s /usr/include/ /include

Then flightgear and simgear can be compiled without modifications.

Same issue with the INTERFACE_INCLUDE_DIRECTORIES in 2020.1.3-1: I had to remove ;/include; on line 66 to make flightgear compile.

@Potomac: thanks for the tip about /include in INTERFACE_INCLUDE_DIRECTORIES, I can confirm this bug every time I build and install this package. I am unsure why you wrote "Sometimes" the extra /include is added every time.

@Potomac: yes the error message was clear about this required change and this works well.

Here is a workaround for building Simgear 2019.1 with openscenegraph 3.6.5 : just add the "-fpermissive" option to -DCMAKE_CXX_FLAGS in PKGBUILD for cmake :

build() {
  cd "$srcdir"/simgear-$pkgver
  cmake -DCMAKE_CXX_FLAGS="-fpermissive" -DCMAKE_INSTALL_PREFIX=/usr  -DCMAKE_INSTALL_LIBDIR=lib -DCMAKE_BUILD_TYPE=Release -DENABLE_TESTS=off ../simgear-${pkgver}
  make
}

Instead of downgrading openscenegraph 3.6.5-1 to 3.6.4 we should be able to find a workaround, a patch for the file src/simgear-2019.1.1/simgear/canvas/elements/CanvasText.cxx.

Perhaps someone in a bugreport (flightgear's bugzilla) has already wrote a patch.