Arch Linux User Repository

Just as a reminder, this is a VCS (ends in -git) package meaning that every time you build this package, it actually pulls the latest code from git. The version number on AUR and in the PKGBUILD is only representative of the last time the PKGBUILD file was itself touched.

Citation: https://wiki.archlinux.org/index.php/Arch_User_Repository#Flagging_packages_out-of-date

Note: VCS packages are not considered out-of-date when the pkgver changes and are not to be flagged in this case.

Hey, first of all thank you for maintaining this package.

I ran into a problem which is more related to Rust than to this program specifically, but could you set

export TMPDIR=$XDG_RUNTIME_DIR

at the beginning of the build() section in the PKGBUILD?

Otherwise the tests fail if /tmp is mounted with noexec (which it should be security wise and is if you use systemd's tmp.mount (# systemctl mask tmp.mount)):

 Running unittests (target/release/deps/rescrobbled-a1d59d1723f4e26d)

running 1 test test filter::tests::test_filter_script ... FAILED

failures:

---- filter::tests::test_filter_script stdout ---- thread 'filter::tests::test_filter_script' panicked at 'assertion failed: (left == right) left: Err("Failed to run filter script: Permission denied (os error 13)"), right: Ok(Filtered(Track { artist: "Artist=lorem", title: "Title=ipsum", album: "Album=dolor" }))', src/filter.rs:97:9 note: run with RUST_BACKTRACE=1 environment variable to display a backtrace

failures: filter::tests::test_filter_script

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; > finished in 0.00s

error: test failed, to rerun pass '--bin rescrobbled' ==> ERROR: A failure occurred in check(). Aborting... error making: rescrobbled-git

You can reproduce and test this with
# mount -o remount,noexec /tmp
and
# mount -o remount,exec /tmp

References:
https://github.com/rust-lang/cargo/issues/4350
https://github.com/rust-lang/cargo/issues/4350#issuecomment-340215811

Just as a reminder, this is a VCS (ends in -git) package meaning that every time you build this package, it actually pulls the latest code from git. The version number on AUR and in the PKGBUILD is only representative of the last time the PKGBUILD file was itself touched.

Citation: https://wiki.archlinux.org/index.php/Arch_User_Repository#Flagging_packages_out-of-date

Note: VCS packages are not considered out-of-date when the pkgver changes and are not to be flagged in this case.