Package Details: python-youtube-search-git 1.1.1.r31.e021809-1

Git Clone URL: https://aur.archlinux.org/python-youtube-search-git.git (read-only, click to copy)
Package Base: python-youtube-search-git
Description: Perform YouTube video searches without the API
Upstream URL: https://github.com/joetats/youtube_search
Keywords: python search youtube
Licenses: MIT
Conflicts: python-youtube-search
Provides: python-youtube-search
Submitter: deepjyoti30
Maintainer: deepjyoti30
Last Packager: deepjyoti30
Votes: 3
Popularity: 2.53
First Submitted: 2020-07-26 14:25
Last Updated: 2020-11-20 05:42

Dependencies (4)

Required by (3)

Sources (1)

Latest Comments

Kr1ss commented on 2020-11-19 15:23

Oops I'm sorry I missed something important.

The git commands in pkgver() won't work because the package pulls the zip archive from Github instead of the actual repository. To make it work, the source array needs to be

source=("git+https://github.com/joetats/youtube_search.git")

and with that, all instances of cd (i.e. inside pkgver(), build() and package()) need to be changed to

cd "youtube_search"

Sorry, and thx for your quick response !

deepjyoti30 commented on 2020-11-19 15:12

@Kr1ss Thanks for the heads up. I just updated the PKGBUILD. Should be all right now.

Kr1ss commented on 2020-11-19 14:16

That's cool, thank you very much for all your contributions to that awesome project then ! (And for adding the provides/conflicts arrays of course :D)

I do also appreciate that you've introduced a pkgver() function with the latest update. I see that upstream is following a version scheme though, despite the fact that there are no official releases (yet?). If you're interested, you could dynamically integrate this version number in your package's version by grabbing it from setup.py, by doing something like :

pkgver() {
    cd youtube_search
    printf '%s.r%s.%s' \
    "$(grep version= setup.py | sed 's/^\s*version="\(.*\)".*/\1/')" \
    "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
}

The additional printf argument basically filters the plain version number out of this file. The current build's pkgver would then be 1.1.1.r31.e021809 rather than r31.e021809 - which is fine too, of course, I personally just like to use upstream versioning where it's possible.

Cheers !

deepjyoti30 commented on 2020-11-19 04:47

@Kr1ss I would totally consider the change. I'm actually a contributor of playx and I made the PR to add youtube-search as a dependency due to some internal changes to the package.

Anyway, I have made the change to the PKGBUILD!

Kr1ss commented on 2020-11-17 20:29

Hi @deepjyoti30, thx a lot for sharing this package !

One of my packages is playx-git, which depends on this one. I'm just stepping by to ask if you'd consider to add

provides=("${pkgname%-git}")
conflicts=("${pkgname%-git}")

to your PKGBUILD. This would give me the chance to depend on python-youtube-search (rather than ...-git). In case there will be an official youtube-search release at some point, users would be able to choose if they prefer python-youtube-search or ...-git as dependency.

Thx in advance, cheers !