Package Details: python-skia-pathops 0.4.1-1

Git Clone URL: https://aur.archlinux.org/python-skia-pathops.git (read-only, click to copy)
Package Base: python-skia-pathops
Description: Python bindings for the Skia library’s Path Ops
Upstream URL: https://github.com/fonttools/skia-pathops
Licenses: BSD
Submitter: thrasibule
Maintainer: thrasibule (caleb)
Last Packager: caleb
Votes: 1
Popularity: 0.28
First Submitted: 2019-08-19 18:25
Last Updated: 2020-05-06 07:42

Latest Comments

caleb commented on 2020-03-26 07:57

Thanks for bumping this. I'd like to suggest a couple of tweaks in line with the Arch Python package guidelines. I happened to catch PyPI in maintenance mode and the URL recommended on the Wiki is more stable. Also I broke up the package() function into build() and package() steps and made a few other tweeks such as ordering keys and dropping empty ones. Please consider this patch (should apply via git am):

From 0c1a15937e357282b0ddebbb47f6d2d3d0bf7a3e Mon Sep 17 00:00:00 2001
From: Caleb Maclennan <caleb@alerque.com>
Date: Thu, 26 Mar 2020 10:55:48 +0300
Subject: [PATCH] Use stable URL, split build() and package(), cleanup per
 guidelines

Signed-off-by: Caleb Maclennan <caleb@alerque.com>
---
 .SRCINFO |  6 +++---
 PKGBUILD | 38 ++++++++++++++++++++++----------------
 2 files changed, 25 insertions(+), 19 deletions(-)

diff --git a/.SRCINFO b/.SRCINFO
index 23dffcd..eb357d8 100644
--- a/.SRCINFO
+++ b/.SRCINFO
@@ -1,7 +1,7 @@
 pkgbase = python-skia-pathops
-   pkgdesc = Python bindings for the Skia library's Path Ops.
+   pkgdesc = Python bindings for the Skia library’s Path Ops
    pkgver = 0.3.0
-   pkgrel = 1
+   pkgrel = 2
    url = https://github.com/fonttools/skia-pathops
    arch = x86_64
    license = BSD
@@ -10,7 +10,7 @@ pkgbase = python-skia-pathops
    makedepends = cython
    makedepends = python-setuptools
    depends = python
-   source = https://pypi.org/packages/source/s/skia-pathops/skia-pathops-0.3.0.zip
+   source = https://files.pythonhosted.org/packages/source/s/skia-pathops/skia-pathops-0.3.0.zip
    sha256sums = 9d5ad3d0e7be0e6ba542ad769a8149f97bf0d431520167840ad3fc4472d16585

 pkgname = python-skia-pathops
diff --git a/PKGBUILD b/PKGBUILD
index ebd2f19..88a2017 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,26 +1,32 @@
 # Maintainer: Guillaume Horel <guillaume.horel@gmail.com>
-pkgname='python-skia-pathops'
-_pkgname='skia-pathops'
-pkgver='0.3.0'
-pkgrel=1
-pkgdesc="Python bindings for the Skia library's Path Ops."
-url="https://github.com/fonttools/skia-pathops"
-checkdepends=('python-pytest' 'python-pytest-cython')
+# Contributor: Caleb Maclennan <caleb@alerque.com>
+
+pkgname=python-skia-pathops
+_pkgname=${pkgname#python-}
+pkgver=0.3.0
+pkgrel=2
+pkgdesc='Python bindings for the Skia library’s Path Ops'
+arch=('x86_64')
+url="https://github.com/fonttools/$_pkgname"
+license=('BSD')
 depends=('python')
 makedepends=('cython' 'python-setuptools')
-optdepends=()
-license=('BSD')
-arch=('x86_64')
-source=("https://pypi.org/packages/source/${_pkgname:0:1}/$_pkgname/$_pkgname-$pkgver.zip")
+checkdepends=('python-pytest' 'python-pytest-cython')
+source=("https://files.pythonhosted.org/packages/source/${_pkgname::1}/$_pkgname/$_pkgname-$pkgver.zip")
 sha256sums=('9d5ad3d0e7be0e6ba542ad769a8149f97bf0d431520167840ad3fc4472d16585')

-package() {
-    cd "${srcdir}/${_pkgname}-${pkgver}"
-    python setup.py install --root="${pkgdir}" --optimize=1
+build() {
+    cd "$_pkgname-$pkgver"
+    python setup.py build
+    python setup.py build_ext --inplace
 }

 check() {
-    cd "$srcdir/$_pkgname-${pkgver}"
-    python setup.py build_ext --inplace
+    cd "$_pkgname-$pkgver"
     PYTHONPATH="src/python" pytest
 }
+
+package() {
+    cd "$_pkgname-$pkgver"
+    python setup.py install --root="$pkgdir" --optimize=1 --skip-build
+}
-- 
2.26.0