Arch Linux User Repository

Here's a cleaner version of the PKGBUILD (no empty variables, no split-package syntax for a single package, consistent user of "install" command and use of _pkgname variable where appropriate). You can replace the current PKGBUILD with this without bumping the release because the built package is equivalent.

# Contributor: Johannes Dewender  arch at JonnyJD dot net
pkgname='python-rtslib-fb'
_pkgname=rtslib-fb
pkgver=2.1.74
pkgrel=1
pkgdesc="free branch version of the LIO target API"
arch=('any')
url="https://github.com/open-iscsi/$_pkgname"
license=('Apache')
depends=('python' 'python-six' 'python-pyudev')
conflicts=('python2-rtslib' 'targetcli-fb<=2.1.fb31')
makedepends=('python-setuptools' 'python-pyudev')
source=(
  "https://github.com/open-iscsi/$_pkgname/archive/v${pkgver}.tar.gz"
  target.service
)
sha512sums=(
  '181b57f699dd4e6bc050585e1abffe75a7eaf5ae8325220d61d37f932912f2cec878c4643172c584f0d4c231441d25ff0e09aa1f48c2305061b75acdce051c86'
  '3c634f1c466d0a8c3dd2b57a230438aaeeb0e66324863a2ded57dd69a2ca5946f83c4ab511766f510f3e63b43aedcf7e368bcf5bc325ee69c016bb0bb2612de5'
)

package() {
  cd "$srcdir/$_pkgname-$pkgver"
  python setup.py install --root="$pkgdir/" --optimize=1
  install -Dm644 doc/targetctl.8 "$pkgdir/usr/share/man/man8/targetctl.8"
  install -Dm644 doc/saveconfig.json.5 "$pkgdir/usr/share/man/man5/saveconfig.json.5"

  install -dm755 "$pkgdir/etc/target/backup"
  install -Dm644 "$srcdir/target.service" "$pkgdir/usr/lib/systemd/system/target.service"
}

# vim:set ts=2 sw=2 et:

For some reason, upstream URL is from github user "agrover", instead of "open-iscsi". When going to agrover, it makes it look like this package is up to date with fb69, but the real upstream released 2.1.70.

Downloaded source filenames must be unique, for those who set SRCDEST in /etc/makepkg.conf. See https://wiki.archlinux.org/index.php/PKGBUILD#source

Please add something like this to the beginning of source:

source=("${_pkgname}-${pkgver}.tar.gz"::https...

May have to just drop the Python 2 support.

Yes, it builds fine without the python2 stuff (and targetcli just works).

I'll have a look at this on the weekend. May have to just drop the Python 2 support.

I got to this package trying to install targetcli-fb, which is unable to install due to the python2-pyudev package being unavailable

Looks like the dependency python2-pyudev has been deleted, making this uninstallable.

Yes the original branch doesn't support Python 3.

However, the point was rather that python-rtslib-fb is the "main" package containing some extra (non-python) files, which were also included in python2-rtslib (or rather were created when python2-rtslib was run the first time..).

AFAIK there is no maintained python2-rtslib in AUR ATM.

The conflicts array for python-rtslib-fb contains python2-rtslib. Presumably, it should be changed to python-rtslib. OTOH, I'm not sure the Datera version supports Python 3 so maybe it's moot.

Thanks, that makes sense. Fixed (in rtslib and configshell).