Package Details: python-opensubtitlesdownload 4.1-1

Git Clone URL: https://aur.archlinux.org/python-opensubtitlesdownload.git (read-only, click to copy)
Package Base: python-opensubtitlesdownload
Description: Helps you quickly find and download subtitles for your favorite videos from OpenSubtitles.org
Upstream URL: https://emeric.io/OpenSubtitlesDownload
Licenses: GPL3
Provides: OpenSubtitlesDownload
Submitter: tyrannis.hawk
Maintainer: tyrannis.hawk
Last Packager: tyrannis.hawk
Votes: 1
Popularity: 0.37
First Submitted: 2020-06-29 08:50
Last Updated: 2020-06-29 08:50

Dependencies (5)

Required by (0)

Sources (1)

Latest Comments

ignapk commented on 2020-12-05 03:14

Hi, I've got some comments on the PKGBUILD:

  1. gzip is required by base and in the base-devel group so I think it can be removed from dependencies

  2. Maybe package description could mention that it can be used as nautilus script? i.e. "Python nautilus-compatible script to download subtitles form opensubtitles.org"

  3. GPL3 is included in the licenses package so there's no need to copy the license file in package()

  4. The downloaded source filename isn't unique, so alternative one should be specified in the source array: source=("$_pkgname-$pkgver::https://github.com/emericg/$_pkgname/archive/v$pkgver.tar.gz")

  5. You should install the desktop files from $_pkgname-$pkgver/desktop-files to $pkgdir/usr/share/applications/ with install -Dm644 source dest

  6. I'd also patch them to remove the quotations marks from the exec= part with sed 's/"%F"/%F/' -i "$_pkgname-$pkgver/desktop-files/$_pkgname-gnome.desktop" in prepare(), at least until it's fixed upstream EDIT: https://github.com/emericg/OpenSubtitlesDownload/commit/e8e090150ff10d3a94ab4f191ed7457045b81a00, so the next release will have it fixed

  7. Perhaps user could be informed after installation that it can be used as a nautilus script if put in ~/.local/share/nautilus/scripts directory?