Arch Linux User Repository

opencv3.patch need update for opencv4 https://pastebin.com/ddbEwh6W

For a build in a minimal environment package gtk3 was a missing (make) dependency.

I get the following build error when extra/imagemagick6 is installed:

/path/to/build/src/pfstools-2.1.0/src/fileformat/pfsinimgmagick.cpp: In function ‘void readFrames(int, char)’:
/path/to/build/src/pfstools-2.1.0/src/fileformat/pfsinimgmagick.cpp:117:29: error: ‘class Magick::Image’ has no member named ‘matte’
     bool hasAlpha = imImage.matte();
                             ^~~~~
/path/to/build/src/pfstools-2.1.0/src/fileformat/pfsinimgmagick.cpp:132:39: error: ‘QuantumDepth’ was not declared in this scope
     const float maxValue = (float)(1<<QuantumDepth) - 1;
                                       ^~~~~~~~~~~~
/path/to/build/src/pfstools-2.1.0/src/fileformat/pfsinimgmagick.cpp:132:39: note: suggested alternative: ‘QuantumRange’
     const float maxValue = (float)(1<<QuantumDepth) - 1;
                                       ^~~~~~~~~~~~
                                       QuantumRange
/path/to/build/src/pfstools-2.1.0/src/fileformat/pfsinimgmagick.cpp:134:21: error: ‘PixelPacket’ in namespace ‘Magick’ does not name a type
       const Magick::PixelPacket pixels =
                     ^~~~~~~~~~~
/path/to/build/src/pfstools-2.1.0/src/fileformat/pfsinimgmagick.cpp:138:31: error: ‘pixels’ was not declared in this scope
         (X)(pixInd) = (float)pixels[c].red / maxValue;
                               ^~~~~~
/path/to/build/src/pfstools-2.1.0/src/fileformat/pfsinimgmagick.cpp:138:31: note: suggested alternative: ‘pixInd’
         (*X)(pixInd) = (float)pixels[c].red / maxValue;
                               ^~~~~~
                               pixInd
make[2]:  [src/fileformat/CMakeFiles/pfsinimgmagick.dir/build.make:63: src/fileformat/CMakeFiles/pfsinimgmagick.dir/pfsinimgmagick.cpp.o] Error 1
make[1]:  [CMakeFiles/Makefile2:804: src/fileformat/CMakeFiles/pfsinimgmagick.dir/all] Error 2

Fixed.

@bartus: thank you for providing the patch.

Oh, I see. I always build packages in a clean chroot so it is built without opencv, hence I did not see any problem.

Got the same error as @dreleck. Figure out this was related to opencv2 should be listed as dependency of pfstools not opencv(current version in arch repo is 3.2).
Make some changes to 'pfsalign.cpp' for compatibility with opencv3.
http://pastebin.com/ZQQ1yhMj
It build fine, but I can't test it properly with some sample data.

Thanks, I updated it to 2.0.5 which builds fine here.

Fails to build:

Scanning dependencies of target pfsalign
[100%] Building CXX object src/camera/CMakeFiles/pfsalign.dir/pfsalign.cpp.o
/var/tmp/yaourt-tmp-felics/aur-pfstools/src/pfstools-2.0.4/src/camera/pfsalign.cpp:46:42: fatal error: opencv2/nonfree/features2d.hpp: No such file or directory
#include <opencv2/nonfree/features2d.hpp>
^
compilation terminated.
make[2]: *** [src/camera/CMakeFiles/pfsalign.dir/build.make:63: src/camera/CMakeFiles/pfsalign.dir/pfsalign.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:2064: src/camera/CMakeFiles/pfsalign.dir/all] Error 2
make: *** [Makefile:150: all] Error 2
==> ERROR: A failure occurred in build().
Aborting...


Although /usr/include/opencv2/features2d/features2d.hpp is present!, the source code seems to specify wrong path ("nonfree").

Hi I am trying to build pfstools with Matlab support but I am getting the following error:

Scanning dependencies of target pfs_transform_colorspace
[ 43%] Building CXX object src/matlab/CMakeFiles/pfs_transform_colorspace.dir/pfs_transform_colorspace.cpp.o
[ 44%] Generating moc_main.cxx
[ 44%] Generating moc_pfsview_widget.cxx
[ 45%] Building CXX object src/hdrhtml/CMakeFiles/pfsouthdrhtml.dir/hdrhtml.cpp.o
Scanning dependencies of target pfsview
[ 45%] Building CXX object src/pfsview/CMakeFiles/pfsview.dir/main.cpp.o
Unknown MEX argument '-O3'.
src/matlab/CMakeFiles/pfs_transform_colorspace.dir/build.make:62: recipe for target 'src/matlab/CMakeFiles/pfs_transform_colorspace.dir/pfs_transform_colorspace.cpp.o' failed
make[2]: *** [src/matlab/CMakeFiles/pfs_transform_colorspace.dir/pfs_transform_colorspace.cpp.o] Error 255
CMakeFiles/Makefile2:1389: recipe for target 'src/matlab/CMakeFiles/pfs_transform_colorspace.dir/all' failed
make[1]: *** [src/matlab/CMakeFiles/pfs_transform_colorspace.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 46%] Building CXX object src/pfsview/CMakeFiles/pfsview.dir/pfsview_widget.cpp.o
/home/theodore/package_builds/pfstools/src/pfstools-2.0.4/src/pfsview/pfsview_widget.cpp: In function ‘void mapFrameToImage(pfs::Array2D*, pfs::Array2D*, pfs::Array2D*, QImage*, float, float, RGBClippingMethod, LumMappingMethod, InfNaNTreatment, NegativeTreatment)’:
/home/theodore/package_builds/pfstools/src/pfstools-2.0.4/src/pfsview/pfsview_widget.cpp:353:92: warning: iteration 256u invokes undefined behavior [-Waggressive-loop-optimizations]
lutPixFloor[257+p+1] = getInverseMapping( mappingMethod, p_left, minValue, maxValue );
^
/home/theodore/package_builds/pfstools/src/pfstools-2.0.4/src/pfsview/pfsview_widget.cpp:351:23: note: containing loop
for( int p = 0; p < 257; p++ ) {
^
/home/theodore/package_builds/pfstools/src/pfstools-2.0.4/src/pfsview/pfsview_widget.cpp: In function ‘void mapFrameToImage(pfs::Array2D*, pfs::Array2D*, pfs::Array2D*, QImage*, float, float, RGBClippingMethod, LumMappingMethod, InfNaNTreatment, NegativeTreatment)’:
/home/theodore/package_builds/pfstools/src/pfstools-2.0.4/src/pfsview/pfsview_widget.cpp:353:92: warning: iteration 256u invokes undefined behavior [-Waggressive-loop-optimizations]
lutPixFloor[257+p+1] = getInverseMapping( mappingMethod, p_left, minValue, maxValue );
^
/home/theodore/package_builds/pfstools/src/pfstools-2.0.4/src/pfsview/pfsview_widget.cpp:351:23: note: containing loop
for( int p = 0; p < 257; p++ ) {
^
[ 47%] Building CXX object src/pfsview/CMakeFiles/pfsview.dir/luminancerange_widget.cpp.o
[ 47%] Building CXX object src/pfsview/CMakeFiles/pfsview.dir/histogram.cpp.o
[ 47%] Linking CXX executable pfsouthdrhtml
[ 47%] Built target pfsouthdrhtml
[ 48%] Building CXX object src/pfsview/CMakeFiles/pfsview.dir/resources.cpp.o
[ 49%] Building CXX object src/pfsview/CMakeFiles/pfsview.dir/moc_main.cxx.o
[ 49%] Building CXX object src/pfsview/CMakeFiles/pfsview.dir/moc_pfsview_widget.cxx.o
[ 50%] Building CXX object src/pfsview/CMakeFiles/pfsview.dir/moc_luminancerange_widget.cxx.o
[ 51%] Linking CXX executable pfsview
[ 51%] Built target pfsview
Makefile:149: recipe for target 'all' failed
make: *** [all] Error 2
==> ERROR: A failure occurred in build().
Aborting...

I have set correctly the path to Matlab root by -DMATLAB_ROOT=/home/theodore/matlab/r2015b/

Also another issue is that if I try to build it without Matlab, support I get the following error:

Scanning dependencies of target pfsalign
[ 90%] Building CXX object src/camera/CMakeFiles/pfsalign.dir/pfsalign.cpp.o
/home/theodore/package_builds/pfstools/src/pfstools-2.0.4/src/camera/pfsalign.cpp:46:42: fatal error: opencv2/nonfree/features2d.hpp: No such file or directory
compilation terminated.
src/camera/CMakeFiles/pfsalign.dir/build.make:62: recipe for target 'src/camera/CMakeFiles/pfsalign.dir/pfsalign.cpp.o' failed
make[2]: *** [src/camera/CMakeFiles/pfsalign.dir/pfsalign.cpp.o] Error 1
CMakeFiles/Makefile2:2026: recipe for target 'src/camera/CMakeFiles/pfsalign.dir/all' failed
make[1]: *** [src/camera/CMakeFiles/pfsalign.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 91%] Building CXX object src/tmo/mantiuk08/CMakeFiles/pfstmo_mantiuk08.dir/display_function.cpp.o
[ 92%] Linking CXX executable pfstmo_ferradans11
[ 92%] Built target pfstmo_ferradans11
[ 93%] Building CXX object src/tmo/mantiuk08/CMakeFiles/pfstmo_mantiuk08.dir/display_size.cpp.o
[ 93%] Building CXX object src/tmo/mantiuk08/CMakeFiles/pfstmo_mantiuk08.dir/cqp/cqpminimizer.cpp.o
[ 94%] Building CXX object src/tmo/mantiuk08/CMakeFiles/pfstmo_mantiuk08.dir/cqp/initial_point.cpp.o
[ 95%] Building CXX object src/tmo/mantiuk08/CMakeFiles/pfstmo_mantiuk08.dir/cqp/mg_pdip.cpp.o
[ 95%] Linking CXX executable pfstmo_mantiuk08
[ 95%] Built target pfstmo_mantiuk08
Makefile:149: recipe for target 'all' failed
make: *** [all] Error 2
==> ERROR: A failure occurred in build().
Aborting...

which I guess it means that it is not compatible with Opencv 3.1 that I have installed. Any ideas how I can bypass these errors?

Thanks.

@Morn: that would help if I run git add at all. To explain – I use a bunch of oneliners (https://bitbucket.org/stativ/scripts/src/tip/shell/?at=default) one of which generates .SRCINFO, adds it, does commit and pushes the changes all at once. One just must not forget to add other changes. Well, time to change "git commit" to "git commit -a" ;-)