Arch Linux User Repository

can you check the checksums ?

Validating source files with sha256sums...

petsc-lite-3.13.1.tar.gz ... Passed

test_optdepends.sh ... FAILED

@xantares: This is the first time that the extensive test suite (including popups) is exectuted. I'm not sure if that is the intended beavior, I guess not.

could "make test" be run with xvfb-run to avoid popups ?

hypre's latest update moved all include files in /usr/include/hypre, test_optdepends.sh should be updated.

When building this with aurutils the build fails with:

==> Starting prepare()...
rm: cannot remove '/logdest/logpipe.K4ZsD575': No such file or directory
==> ERROR: A failure occurred in prepare().

This seems to be an issue somewhere in the build toolchain (see https://github.com/AladW/aurutils/issues/19) but since I never had the issue with any other package I suggest just working around it by changing:

  while IFS= read file; do
    sed -i "s#$MATCH#\\1python2#" "$file"
  done < <( find ${srcdir} -name "*" -type f -exec grep -le "$MATCH" \{\} + )

to:

  find ${srcdir} -name "*" -type f -exec grep -le "$MATCH" \{\} + | \
    while IFS= read file; do
      sed -i "s#$MATCH#\\1python2#" "$file"
    done

(that works for me)

I'm disowning this package because I don't have the time to handle all dependency detection and their supported versions. I've created a petsc-git pacakge which downloads and installs all supported dependencies with eventual patches.

HYPRE detection is currently broken, the correct version should be 2.14.0 and the naming scheme for the so file is libHYPRE-x.y.z.so now. Replacing the corresponding lines 14/15 in test_optdepends.sh with these fixes the problem:

    VERSION_MIN=2.14.0
    VERSION=$(readlink -f '/usr/lib/libHYPRE.so' | sed -r 's/^.*libHYPRE-(.*)\.so/\1/')

Do we really need this step?

# src for tutorials
cp -r ${_build_dir}/src ${pkgdir}/usr/share/doc/$pkgname/

The src folder by itself is around 147M. Should it be enough just cp -r ${_build_dir}/doc ${pkgdir}/usr/share/doc/$pkgname?

I think that would make sense only if we actually installed petsc in the system directories under /usr/local . I'm not sure what the policy is on that...

Should we also copy /opt/petsc/linux-c-opt/lib/pkgconfig/PETSc.pc to /usr/share/pkgconfig? I run pkg-config --cflags PETSc and get Package petsc was not found in the pkg-config search path