Package Details: path-of-building-community-git 2.1.0.r4249.59.514-1

Git Clone URL: https://aur.archlinux.org/path-of-building-community-git.git (read-only, click to copy)
Package Base: path-of-building-community-git
Description: An offline build planner for Path of Exile using PoBFrontend, LocalIdentity's fork
Upstream URL: https://github.com/PathOfBuildingCommunity/PathOfBuilding
Licenses: MIT
Submitter: bcareil
Maintainer: bcareil
Last Packager: bcareil
Votes: 8
Popularity: 0.71
First Submitted: 2020-03-14 08:43
Last Updated: 2021-04-15 16:53

Latest Comments

« First ‹ Previous 1 2 3 4 Next › Last »

binarydepth commented on 2021-02-24 07:33

Hunk #2 FAILED at 917. 1 out of 2 hunks FAILED -- saving rejects to file Modules/Main.lua.rej ==> ERROR: A failure occurred in prepare(). Aborting...

bcareil commented on 2021-02-07 16:07

Each time I allocate a skill point with "Show Node Power" enabled, the entire program locks up.

Ah, good catch. As I never use the windows version, I thought that was normal. It turns out that the fix was trivial. And I took this opportunity to also do some optimizations. Mostly low hanging fruits.

their tool can work well in Linux!

It can. However, the frontend that we use was only meant as a proof of concept. And so it has quite a few shortcoming still.

BujuArena commented on 2021-02-06 23:38

Oh, nice! I installed it again and was able to allocate skill points with "Show Node Power" enabled, without the program crashing. Awesome. Thanks for the fix!

However, I noticed a difference from the wine version which affects usability in this way. Each time I allocate a skill point with "Show Node Power" enabled, the entire program locks up. I compared this behavior with the Windows release in wine, and the wine version does not lock up. Instead, it just takes a while to finish recalculating, while you can continue to use the interface. It looks like the Linux version is somehow executing the node power calculation synchronously instead of asynchronously, blocking interactivity.

Sorry if it seems I'm always commenting something negative. I am an advocate for Linux superiority, and the PoE community should recognize that their tool can work well in Linux!

I wonder why they used lua 5.1 anyway. Lua 5.3 was released in January 2015, more than a year before their first commit.

bcareil commented on 2021-02-06 21:50

Thanks for the kind word BujuArena.

It turns out that lua51-zlib is not needed. I had it installed and thought it was required, but that is actually just zlib that is needed as they made their own lua wrapper for it.

As for newer versions of lua, we are at the mercy of upstream. E.g. the bitop module/package does not exist for lua 5.4 because bitwise operation are now native. Which means that upstream would have to convert their code base for it to work with lua 5.4.

I'd appreciate if you could give it a try, but I do understand people going the wine route. It is the one that is the most likely to work long term. And people are already using wine for PoE, so why not for related tools.

Also, I believe the wine version supports auto-update, which is neat. I think that is the next thing I'll try to port over. For when I get a bit of free time to work on pobfrontend.

BujuArena commented on 2021-02-06 18:46

Thanks for your effort. However, when I try to build now, it says I'm missing the dependency lua51-zlib. I searched the AUR and a package providing that doesn't exist there, nor in the Manjaro community repository. I guess this is a Manjaro-only problem, since I see from a Google search that there's an Arch community package providing lua51-zlib. Manjaro has lua53-zlib and lua-zlib though. Would a newer version of lua be better?

I guess I'll uninstall this for now and stick with the Windows version in wine. I'm sorry that I couldn't test it on my machine, despite your heroic effort making it available for other AUR users. I hope someone on Arch can help test.

bcareil commented on 2021-02-06 14:42

So it looks like the bug was coming from luajit as it seems to be limited to 2GB of RAM.

In order to address the issue I had to make quite some changes to the package and so:

  • It is no longer depending on luajit but lua51 instead

  • I am no longer fetching pobfrontend sources from philroberts' repo but from mine, which has the pobfrontend.patch pre-applied as well as the required modifications to compile with lua51 instead of luajit.

I also took this opportunity to fix the makedepends and add git to the list.

I hope that the change will be seamless. I do not expect a change in performances as the JIT was disabled by pobfrontend from what I can tell.

BujuArena commented on 2021-01-29 23:11

My bug report at https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/2065 for the node power crash was closed as unsupported. It seems AUR users will have to figure it out on their own. For now, I'm running the released Windows version with wine and that's working well enough for me. I hope this version can be fixed, but I'm kind of stumped. Since I have a workaround personally with the Windows version via wine, I'm giving up. Thanks for the package.

Morganamilo commented on 2021-01-29 16:38

Git is missing from makedepends

BujuArena commented on 2021-01-28 05:53

I'm also seeing this node power crash.

I have 64 GB of RAM, so if Lua needs more RAM, I'm happy to provide it. I just need to know how. If anyone figures that out, please let me know.

In the mean time, I have reported this issue in the github issue tracker, here: https://github.com/PathOfBuildingCommunity/PathOfBuilding/issues/2065

bcareil commented on 2021-01-15 16:23

I am able to reproduce the bug as well, though I was not able to identify it. At first I thought it was caused by the leak of QImage, but now I am not so sure. What is certain is that the Lua interpreter never free references to images (never call the __gc).

Anyway, that was to say that I do not know whether the bug is in the Lua code (and so to be reported to PathOfBuilding) or in the C++ code (to be reported in pobfrontend).

What is certain is that you reported it to the wrong repository @binarydepth, the correct one would be https://github.com/PathOfBuildingCommunity/PathOfBuilding. But again, I cannot be sure that the error is coming from them.