Package Details: notes-tree 1.0-2

Git Clone URL: https://aur.archlinux.org/notes-tree.git (read-only, click to copy)
Package Base: notes-tree
Description: Note taking (knowledge base) app with tree like notes structure
Upstream URL: https://bitbucket.org/baltic/notestree/src
Licenses: zlib
Submitter: baltic
Maintainer: None
Last Packager: eschwartz
Votes: 2
Popularity: 0.000000
First Submitted: 2017-07-18 11:52
Last Updated: 2017-07-23 17:52

Latest Comments

« First ‹ Previous 1 2

baltic commented on 2017-07-18 15:44

@Eschwartz
> The zlib license needs to be installed with the package, see: https://wiki.archlinux.org/index.php/PKGBUILD#license

What i see there is:
The BSD, MIT, zlib/png and Python licenses are special cases and could not be included in the licenses package

About dependency on gtk-update-icon-cache and such you are also terribly wrong, according to the wiki.
And there is no official policy about -j$(nproc)

[CENSORED]

eschwartz commented on 2017-07-18 15:35

gtk-update-icon-cache and desktop-file-utils should not be dependencies, as this package does not actually depend on them. Back in the bad old days, before pacman hooks, these dependencies would come together with a post_install hook to run the provided commands, but thankfully none of that is necessary anymore.

You don't quote "$pkgdir" in the package() function, which means this package will fail embarrassingly if built from "~/aur packages/notes-tree/" (or anything else with a space in the directory name).
The zlib license needs to be installed with the package, see: https://wiki.archlinux.org/index.php/PKGBUILD#license
Please remove the empty validpgpkeys=() array.
-j$(nproc) is a bad policy to override the default MAKEFLAGS, users are responsible for declaring in makepkg.conf how many jobs they want to overload their CPU with and PKGBUILDs are responsible for setting that back to 1 if the build system doesn't declare proper target dependencies and therefore breaks on parallel builds.

You were warned already, and responded with atrocious attitude which means IMHO Scimmia was right to cross-post here...
https://bbs.archlinux.org/viewtopic.php?id=228309
https://bbs.archlinux.org/viewtopic.php?id=228335

baltic commented on 2017-07-18 14:32

@Scimmia So you are going to follow me all over the internets to post your baseless nonsense out of pure hate? Dude, get a life!

Scimmia commented on 2017-07-18 12:42

WARNING: Bad PKGBUILD, and the maintainer refuses to fix it.