Arch Linux User Repository

Some things I noticed when looking over this package:

1. The AUR submission guidelines state:

   Packages that use prebuilt deliverables, when the sources are available, must use the -bin suffix.

   This seems to be the case for this package, so it should be renamed to nbtexplorer-bin.

2. The nbtexplorer script

   1. does not use exec,
   2. silences stdout and stderr and
   3. does not propagate commandline arguments.

   Please change it to this:

   #!/bin/sh
   exec mono /usr/share/nbtexplorer/NBTExplorer.exe "$@"
   

3. With the nbtexplorer script changed, please add %F to the Exec= line in nbtexplorer.desktop to properly advertise the program behavior to the desktop environment.

4. The license is stated to be unknown, however the repo has a LICENSE.txt containing the MIT license. Please change the license field to MIT and add the file to the package as /usr/share/licenses/<pkgname>/LICENSE.txt.

5. The file permissions seem off. Every other package I’ve seen uses 755 and 644 instead of 555 and 444.

6. According to the CLR Package Guidelines, you should set arch to any and add !strip to options.

7. The line provides=('nbtexplorer') is unnecessary when the package is already called nbtexplorer.

8. MD5 is an insecure hashing algorithm. Please upgrade to SHA256 or a comparable algorithm.

9. The ZIP file type is already handled by bsdtar. You can safely remove everything regarding unzip from the PKGBUILD.

The package has already been updated to remove that dependency as you requested. I am unsure why the package ever depended on the xorg-server-utils package.

Make sure you have version 2.7.6-3 and let me know if you notice any other problems and I will fix them.

I've updated the dependencies in a local copy, and it installs & runs fine as far as I can tell.
Check the diff here: https://gist.github.com/founderio/e3085ab8c8927e842fa166ef983028c3

What was the reason for depending on xorg-server-utils? It was a meta-package that has now been removed. It provided the following:

xorg-iceauth xorg-sessreg xorg-xcmsdb xorg-xbacklight xorg-xgamma xorg-xhost xorg-xinput xorg-xmodmap xorg-xrandr xorg-xrdb xorg-xrefresh xorg-xset xorg-xsetroot

FYI there is a git repo for this package at https://github.com/demon012/archlinux-package-nbtexplorer so if I slack again just fork it, make any changes and submit a pull request.

Thanks for the patch ChaosKid42, this package is now updated.

Package seems outdated. Maybe you cold update it to nbtexplorer's current version 2.7.5. Created a patch for PKGBUILD which seems to work: https://bpaste.net/show/b54214f9ce37