Package Details: mojave-gtk-theme-git r365.5e15719-1

Git Clone URL: https://aur.archlinux.org/mojave-gtk-theme-git.git (read-only, click to copy)
Package Base: mojave-gtk-theme-git
Description: A Mac OSX like theme for GTK 3, GTK 2 and Gnome-Shell which supports GTK 3 and GTK 2 based desktop environments like Gnome, Pantheon, XFCE, Mate, etc.
Upstream URL: https://github.com/vinceliuice/Mojave-gtk-theme
Licenses: GPL3
Conflicts: mojave-gtk-theme, mojave-gtk-theme-git-new
Submitter: ArchFeh
Maintainer: ArchFeh
Last Packager: ArchFeh
Votes: 7
Popularity: 2.24
First Submitted: 2020-03-29 22:41
Last Updated: 2020-05-30 23:37

Latest Comments

1 2 Next › Last »

class101 commented on 2020-04-02 13:31

well adding the git tag is a frequent requested change just saying :)

As you can see here

https://aur.archlinux.org/packages/protontricks-git/

Knowing that this is the 333th commit from the beginning is not really relevant informations :)

ArchFeh commented on 2020-03-30 19:24

@class101 oh ya, how a mess version management of mine((..maybe I should follow the way now I took. No need to change it and cause more mess.

class101 commented on 2020-03-30 19:22

You changed the method

https://aur.archlinux.org/cgit/aur.git/commit/?h=mojave-gtk-theme-git&id=d01f29bb4e60516e8a59ea315397d5fd46b5f358

This gives the extra "r"

ArchFeh commented on 2020-03-30 19:19

@class101 actually I never change the format..all is done by $(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)..and I look up the diff, also confused...I will take your tips)) You helped a lot

class101 commented on 2020-03-30 19:17

As we are talking about your versionning format, take this as a tip, non necessary but cosmetic

I would have used a better format

printf "%s" "$(git describe --long --tags | sed 's/^v//;s/([^-]*-)g/r\1/;s/-/./g')"

Would give 2020.03.24.r6.9ac4cc6, you have the git release version 2020.03.24 + 6 commits :)

I use this on octopi-git

class101 commented on 2020-03-30 19:07

Hmm I didn't received the update with yay

I think it is because the pkgver format slighlty changed with a r letter added

yay -Ss mojave

aur/mojave-gtk-theme-git r333.9ac4cc6-1 (+6 5.50%) (Installed: 301.83a02ad-1)

with green color so it thinks 301.83a02ad-1 > r333.9ac4cc6-1 ;D

Well I know how to fix will just uninstall and reinstall but the risk is that users who installed the package prior to the pkgver format will never receive the update.

Any reason you changed the format ?

ArchFeh commented on 2020-03-30 18:59

@class101 Yeah I before always update pkgver instead of pkgrel. Maybe something wrong between the process merge package.. And I will reset pkgrel to 1 again next time.

class101 commented on 2020-03-30 18:54

No problem

Technically you have two choice for updating

  • Nor you bump pkgrel
  • Nor you update manually pkgver=r332.d5cfed8 to the current version generated by the commands from your pkgver() method

Thing to rememeber is to always regenerated SRCINFO when you change the PKGBUILD file

git clone https://github.com/vinceliuice/Mojave-gtk-theme.git
cd Mojave-gtk-theme
printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"

Notice this gives r333.9ac4cc6

So one way to update would have been to keep pkgrel=1 but update pkgver=r333.9ac4cc6

This is just to your liking, how you prefer handling the package, me honestly I prefer updating the pkgver so it is showing on the website, and I just bump pkgrel when I change the file and the git version hasn't changed.

Hope you see what I mean

ArchFeh commented on 2020-03-30 18:45

@class101 Thank you for advise. Have done it.

class101 commented on 2020-03-30 18:41

@ArchFeh

I never installed the -new package, I kept this package and I didn't received the sassc update.

Cause: you kept pkgrel=1 so the update thinks there is no upgrade to grab because the PKGBUILD i downloaded is also pkgrel=1

Solution: If you want to populate changes from a PKGBUILD file, you must bump +1 the pkgrel and regenerate the .SRCINFO file , pkgrel=2 or more should have been used.

Basically, from you local git repo you only need to set pkgrel=2, execute makepkg --printsrcinfo > .SRCINFO and commit both files should be enough.

More infos AUR Submission Guidelines or the PKGBUILD and SRCINFO wiki pages