Package Details: minigalaxy 0.9.4-1

Git Clone URL: https://aur.archlinux.org/minigalaxy.git (read-only, click to copy)
Package Base: minigalaxy
Description: A simple GOG client for Linux
Upstream URL: https://github.com/sharkwouter/minigalaxy
Keywords: client galaxy games gaming GOG good old
Licenses: GPL-3
Submitter: sharkwouter
Maintainer: sharkwouter
Last Packager: sharkwouter
Votes: 10
Popularity: 2.68
First Submitted: 2019-12-25 12:18
Last Updated: 2020-04-20 19:29

Latest Comments

yochananmarqos commented on 2020-03-10 22:20

@sharkwouter: Okay, I'm dumb. I updated to 0.9.3 with my own PKGBUILD before you pushed your commit and didn't notice you added the rm -rf tests. It's in the wrong place, FYI. It should be in a prepare() function.

sharkwouter commented on 2020-03-10 22:02

@yochananmarqos I am not able to reproduce this:

[wouter@wouter-arch minigalaxy]$ tar -tvf minigalaxy-0.9.3-1-any.pkg.tar.xz usr/lib/python3.8/site-packages/tests
tar: usr/lib/python3.8/site-packages/tests: Not found in archive
tar: Exiting with failure status due to previous errors

It is in the source package, but not in the Arch package which is build. Could you try rebuilding in a clean directory?

yochananmarqos commented on 2020-03-10 20:08

@sharkwouter: What deletes what, now? It does indeed install it:

tests
    ├── game.py
    ├── __init__.py
    └── __pycache__
        ├── game.cpython-38.pyc
        └── __init__.cpython-38.pyc

sharkwouter commented on 2020-03-10 19:40

@yochananmarqos it does not actually include the tests directory when running makepkg. It deletes it first.

yochananmarqos commented on 2020-03-10 18:47

This should not be installing the tests directory in site-packages, see Python package guidelines.

I added the following to the package() function for now:

    local site_packages=$(python -c "import site; print(site.getsitepackages()[0])")
    rm -rf "$pkgdir/$site_packages/tests"

Gabriel_Gomes commented on 2020-02-08 16:00

works perfectly