Arch Linux User Repository

I'm getting build failures and midori isn't the most maintained package

Thanks

So @haawda I modified PKGBUILD with small modification keybinding. And I would like to ask @SolarAquarion to submit this modificated PKGBUILD. If modification of keybinding is unreasonable, please give entire prepare() function in comments - do not remove - let user to choose.

# Maintainer: Solomon Choina <shlomochoina@gmail.com>
# Maintainer: Alexander Rødseth <rodseth@gmail.com>
# Contributor: Arkham <arkham at archlinux dot us>
# Contributor: hybraries <macwolf@archlinux.de>
# Contributor: Stefan Husmann <stefan-husmann@t-online.de>
# Contributor: Navi <navitwo.at.gmail.dot.com>
# Contributor: rabyte <rabyte.at.gmail.dot.com>
# Contributor: Johannes Krampf <wuischke.at.amule.dot.org>

pkgname=midori-git
pkgver=v9.0.r7.gd8546ca6
pkgrel=1
pkgdesc='Lightweight web browser based on WebKit and GTK3. Git development version.'
arch=('x86_64' 'i686')
url='https://midori-browser.org/'
license=('LGPL')
depends=('aria2' 'gcr' 'gobject-introspection-runtime' 'libpeas' 'libxss' 'webkit2gtk' 'zeitgeist')
makedepends=('bzr' 'cmake' 'git' 'gobject-introspection' 'intltool' 'ninja' 'vala')
optdepends=('gst-plugins-base: HTML5 OGG videos support'
            'gst-plugins-good: HTML5 H264 and WebM videos support'
            'gst-libav: HTML5 H264 videos support')
provides=('midori')
conflicts=('midori' 'midori-gtk2-git')
options=('!emptydirs')
source=("git+https://github.com/midori-browser/core")
sha256sums=('SKIP')

pkgver() {
  cd "$srcdir/core"
printf "%s" "$(git describe --tags --long | sed 's/\([^-]*-g\)/r\1/;s/-/./g')"
}

prepare() {

cd "$srcdir/core/"

## remove slash bind for find
echo "remove slash bind for find"
sed -i '124 s/("win.find", { "<Primary>f", "slash" });/("win.find", { "<Primary>f"});/' core/browser.vala
}

build() {
  cd "$srcdir/core"
  mkdir -p build
  cd build
  cmake "../" \
    -DCMAKE_INSTALL_PREFIX=/usr \
    -DCMAKE_INSTALL_LIBDIR=lib \
    -DHALF_BRO_INCOM_WEBKIT2=ON \
    -DCMAKE_C_FLAGS="$CFLAGS -fPIC -w" \
    -DVALA_CFLAGS="$CFLAGS -fPIC -w" \
    -G Ninja
  ninja

}

package() {
  cd "$srcdir/core"

  DESTDIR="$pkgdir" ninja -C build  install
}

# vim:set ts=2 sw=2 et: 

If annoying you slash key binding, eg. when are you typing "slash" to URL, you can add to PKGBUILD prepare sections:

prepare() {
cd "$srcdir/core/"
sed -i '124 s/("win.find", { "<Primary>f", "slash" });/("win.find", { "<Primary>f"});/' core/browser.vala
}

The hardcoded part of pkgver seems strange. The version in the repos is at 9.0, why 0.6.0 here? Why not use git --describe?

And the makedependancy to bzr is wrong, I think.

And please do not download to $SRCDEST/core, rename it to midori using the :: syntax, please.

@SolarAquarion Since the Midori development occurs at github, added to the fact that Midori in launchpad is outdated, I will merge midori-bzr into this package. After the merge, this package will incorporate all the votes and comments from midori-bzr. Any objections?

@ponsfoot Thank you! Updated the package.

Upstream has been switched to cmake (from waf).
So, 'cmake' is required as makedepends.
Furthermore, option '--disable-granite' is obsolete (see configure).

Upstream has been switched to cmake (from waf).
So, 'cmake' is required as makedepends.
Furthermore, option '--disable-granite' is obsolete (see CMakeLists.txt).

@xyproto: thanks for the explanation

I don't know how, but it compiled just few seconds ago :D
Midori release 0.5.5~r6363.
Maybe Midori team fixed it