Arch Linux User Repository

Hi @graysky Thanks for the info, I will test it. I'm not using overlayfs snapshots.

@sam - 5.10.4 + lxc builds fine. No patch needed.

Separate issue to building lxc is running it. There is at least one open bug affecting lxc and the 5.10.x series of kernel that has hit me, but it relates to overlayfs snapshots[1] and may or may not concern you.

1. https://github.com/lxc/lxc/issues/3609

@squiddo thanks for the quick patch. Anyway, at the same time I left here the comment I downgraded linux package to previous 5.9 version. Just froze the linux package until upstream correct lxc. Let see if they do it in acceptable time, or else your patch will be very useful. Thanks again!

@squiddo - Yes, that is an response to my ticket re: your PKGBUILD modifications.

@graysky, this is the first time I've looked at this package due to the linux 5.10.3 incompatibility with the core package.

Looks like the core package maintainer might show the reason: https://github.com/archlinux/svntogit-community/commit/13e4f6c6036bcc2ebdde1dfdd50a2ac74094511b#diff-3e341d2d9c67be01819b25b25d5e53ea3cdf3a38d28846cda85a195eb9b7203a

@squiddo - Thanks for the fix. Can you explain why these are needed? The original PKGBUILD never provided any comments.

Here's my quick-and-dirty diff to the PKGBUILD:

diff --git a/PKGBUILD b/PKGBUILD
index 6617738..703914b 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -7,7 +7,7 @@

 pkgname=lxc-git
 _pkgname=lxc
-pkgver=4.0.0.r475.g59c6b0661
+pkgver=4.0.0.r682.gbfcd663fc
 pkgrel=1
 pkgdesc="Linux Containers git version"
 arch=('x86_64' 'armv6h' 'armv7h' 'aarch64')
@@ -45,6 +45,20 @@ prepare() {
   sed -i \
     -e 's|"\\"-//Davenport//DTD DocBook V3.0//EN\\""|"\\"-//OASIS//DTD DocBook XML\\" \\"https://www.oasis-open.org/docbook/xml/4.5/docbookx.dtd\\""|' \
     configure.ac
+
+  sed -i \
+    -e 's/void print_version_exit()/void print_version_exit(void)/' src/lxc/tools/arguments.c
+  sed -i \
+    -e 's/static void free_mnts()/static void free_mnts(void)/' src/lxc/tools/lxc_copy.c
+
+  sed -i \
+    -e 's/static const char \*lxc_log_get_container_name()/static const char *lxc_log_get_container_name(void)/' src/lxc/log.c
+  sed -i \
+    -e 's/inline void lxc_log_options_no_override()/inline void lxc_log_options_no_override(void)/' src/lxc/log.c
+  sed -i \
+    -e 's/char \*get_rundir()/char *get_rundir(void)/' src/lxc/utils.c
+  sed -i \
+    -e 's/static bool apparmor_can_stack()/static bool apparmor_can_stack(void)/' src/lxc/lsm/apparmor.c
 }

 build() {

The code is not compiling with current updated packages:

tools/arguments.c:119:24: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
  119 | __noreturn static void print_version_exit()
      |                        ^~~~~~~~~~~~~~~~~~
tools/arguments.c: In function ‘print_version_exit’:
tools/arguments.c:119:24: error: old-style function definition [-Werror=old-style-definition]
cc1: all warnings being treated as errors
make[3]: *** [Makefile:4010: tools/arguments.o] Error 1
make[3]: Leaving directory '/home/samuel/.cache/yay/lxc-git/src/lxc/src/lxc'
make[2]: *** [Makefile:432: all-recursive] Error 1
make[2]: Leaving directory '/home/samuel/.cache/yay/lxc-git/src/lxc/src'
make[1]: *** [Makefile:371: all] Error 2
make[1]: Leaving directory '/home/samuel/.cache/yay/lxc-git/src/lxc/src'
make: *** [Makefile:529: all-recursive] Error 1
==> ERROR: A failure occurred in build().
    Aborting...
error making: lxc-git