Package Details: lua-format-git r126.2c3edd0-2

Git Clone URL: https://aur.archlinux.org/lua-format-git.git (read-only, click to copy)
Package Base: lua-format-git
Description: LuaFormatter - Code formatter for Lua
Upstream URL: https://github.com/Koihik/LuaFormatter
Licenses: Apache2
Conflicts: LuaFormatter, lua-format
Provides: LuaFormatter, lua-format
Submitter: bilabila
Maintainer: bilabila
Last Packager: bilabila
Votes: 1
Popularity: 0.000000
First Submitted: 2019-06-02 06:36
Last Updated: 2020-01-17 06:28

Dependencies (2)

Required by (1)

  • o (requires lua-format) (optional)

Sources (1)

Latest Comments

bilabila commented on 2020-06-10 15:27

Hi, @Janfel. Thank you for advice. For availability, I do not want to patching dependencies as before. If you are willing to do this in time, you can be a Co-maintainer.

Janfel commented on 2020-06-10 14:47

Can you please change the PKGBUILD to depend on yaml-cpp and antlr4-runtime again? Below is an updated patch that works with the current master.

diff --git a/CMakeLists.txt b/CMakeLists.txt
index f876254..5ad71e7 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -54,8 +54,8 @@ include_directories(
   ${PROJECT_SOURCE_DIR}/generated/
   ${PROJECT_SOURCE_DIR}/third_party/
   ${PROJECT_SOURCE_DIR}/third_party/Catch2/single_include
-  ${PROJECT_SOURCE_DIR}/third_party/yaml-cpp/include
-  ${PROJECT_SOURCE_DIR}/third_party/antlr4/runtime/Cpp/runtime/src
+  /usr/include/yaml-cpp
+  /usr/include/antlr4-runtime
   ${PROJECT_SOURCE_DIR}/src/
   )

@@ -77,19 +77,11 @@ file(GLOB_RECURSE yaml-cpp-src
   ${PROJECT_SOURCE_DIR}/third_party/yaml-cpp/src/*.cpp
   )

-add_library (antlr4-cpp-runtime ${antlr4-cpp-src})
-add_library (yaml-cpp ${yaml-cpp-src})
-
 add_executable(lua-format ${src_dir} src/main.cpp)

-if(WIN32)
-  target_compile_definitions(antlr4-cpp-runtime PRIVATE ANTLR4CPP_EXPORTS)
-  target_compile_definitions(yaml-cpp PRIVATE YAMLCPP_EXPORTS)
-endif()
-
 set_target_properties(lua-format PROPERTIES LINKER_LANGUAGE CXX)

-target_link_libraries(lua-format yaml-cpp antlr4-cpp-runtime ${extra-libs})
+target_link_libraries(lua-format yaml-cpp antlr4-runtime ${extra-libs})

 install(TARGETS lua-format
   RUNTIME DESTINATION bin
@@ -117,7 +109,7 @@ if(BUILD_TESTS)
   endif()

   target_compile_definitions(lua-format-test PUBLIC PROJECT_PATH="${PROJECT_SOURCE_DIR}")
-  target_link_libraries(lua-format-test yaml-cpp antlr4-cpp-runtime ${extra-libs})
+  target_link_libraries(lua-format-test yaml-cpp antlr4-runtime ${extra-libs})

   add_test(all_tests lua-format-test)
 endif()

DanManN commented on 2020-01-16 03:03

The patch doesn't seem to work anymore. I was able to get the package to build by replacing the patch line in prepare with git submodule update --init. Could you please update the PKGBUILD accordingly? This would also remove the depedency on antlr4-runtime as it is linked with the provided one instead.