Package Details: lab 0.17.2-4

Git Clone URL: https://aur.archlinux.org/lab.git (read-only, click to copy)
Package Base: lab
Description: A hub-like tool for GitLab (tagged release)
Upstream URL: https://zaquestion.github.io/lab
Licenses: custom:UNLICENSE
Submitter: simon04
Maintainer: simon04 (caleb)
Last Packager: caleb
Votes: 5
Popularity: 0.55
First Submitted: 2018-01-26 11:37
Last Updated: 2020-05-27 11:21

Dependencies (3)

Required by (0)

Sources (1)

Latest Comments

caleb commented on 2020-05-26 23:27

Thanks for the catch @aperez. I'm unconvinced however that the fix will actually work though. I just did some testing in bash and that inner single quote doesn't actually help — given that the testing scenario is another bash function. The outer double quotes succeed in grouping the contents, but unless you do something fancy like array expansion other arguments still get split, albeit with a leading single quote on the first arg and a trailing single quote on the last arg. I don't know how Go itself handles parsing arguments here. Does it actually handle the single quotes here? Or would it handle if we passed it escaped double quotes instead? Note that this is the syntax recommended in the new Arch packaging guidelines for Go packages, so it's worth figuring out what actually works.

aperez commented on 2020-05-26 22:14

The build command is missing quoting on $LDFLAGS, which can easily result in failure when makepkg.conf defines it with a value that includes spaces. Could you please apply the following fix?

diff --git a/PKGBUILD b/PKGBUILD
index c8ad3bc..1490862 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -29,7 +29,7 @@ build () {
         -buildmode=pie \
         -mod=readonly \
         -modcacherw \
-        -ldflags "-extldflags ${LDFLAGS} -X main.version=$pkgver" \
+        -ldflags "-extldflags '${LDFLAGS}' -X main.version=$pkgver" \
         .
     ./lab completion bash > completion.bash
     ./lab completion zsh > completion.zsh

Thanks!

simon04 commented on 2019-12-31 16:20

@jdorel: Thanks for the pointer. Done in 0.17.2-2 and 0.17.2-3.

jdorel commented on 2019-12-31 16:02

Would you consider adding the ZSH completions in the PKGBUILD ?

caleb commented on 2018-07-20 09:06

The *-2 version of this package has the same upstream version as before (0.12.0) but it will now build from source on the target system. If you prefer to download and install the binary as build upstream you can use the lab-bin package which contains the PKGBUILD as it was in the *-1 package version. Also note there is a lab-git package available if you prefer to build from the master branch HEAD instead of the last tagged release.