Package Details: indicator-kdeconnect-git r599.070ebaa-2

Git Clone URL: https://aur.archlinux.org/indicator-kdeconnect-git.git (read-only, click to copy)
Package Base: indicator-kdeconnect-git
Description: Integrate KDEConnect on desktop environments that use AppIndicators (e.g. Unity)
Upstream URL: https://github.com/bajoja/indicator-kdeconnect
Licenses: GPL
Conflicts: indicator-kdeconnect
Provides: indicator-kdeconnect
Submitter: shimi
Maintainer: zufallsheld
Last Packager: zufallsheld
Votes: 42
Popularity: 0.32
First Submitted: 2015-08-11 19:41
Last Updated: 2018-11-18 18:19

Latest Comments

1 2 3 Next › Last »

kkyy commented on 2021-03-03 07:41

This patch should fix the build error

diff --git a/PKGBUILD b/PKGBUILD
index 0006188..d548864 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -2,25 +2,36 @@
 # Contributor: shimi <shimi.chen@gmail.com>
 # Contributor: Gustavo Castro <gustawho at gmail dot com>
 pkgname=indicator-kdeconnect-git
-pkgver=r599.070ebaa
-pkgrel=2
+pkgver=r625.669bdd5
+pkgrel=1
 _gitname=indicator-kdeconnect
 pkgdesc="Integrate KDEConnect on desktop environments that use AppIndicators (e.g. Unity)"
 arch=('any')
-url="https://github.com/bajoja/indicator-kdeconnect"
+url="https://github.com/b4j4/indicator-kdeconnect"
 license=('GPL')
 conflicts=('indicator-kdeconnect')
 provides=('indicator-kdeconnect')
 depends=('libappindicator-gtk3' 'kdeconnect' 'vala' 'python-requests-oauthlib' 'python-gobject' 'libgee')
 makedepends=('git' 'meson' 'ninja')
-source=('git+https://github.com/bajoja/indicator-kdeconnect.git')
-md5sums=('SKIP')
+source=(
+  'git+https://github.com/bajoja/indicator-kdeconnect.git'
+  'fix-build.patch'
+)
+sha256sums=(
+  'SKIP'
+  'b79c5b3b3cda6b7e9e329ae1ea080f8750dde64025090b9cb534efb7a2c0f537'
+)

 pkgver() {
   cd $_gitname
   printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
 }

+prepare() {
+    cd "$_gitname"
+    patch --forward --strip=1 --input="${srcdir}/fix-build.patch"
+}
+
 build() {
   mkdir build && cd build
   meson ../$_gitname --prefix=/usr  --libdir=/usr/lib
diff --git a/fix-build.patch b/fix-build.patch
new file mode 100644
index 0000000..acc6ff9
--- /dev/null
+++ b/fix-build.patch
@@ -0,0 +1,136 @@
+diff --git a/src/common/iBatteryPlugin.vala b/src/common/iBatteryPlugin.vala
+index a4b3502..5514cc3 100644
+--- a/src/common/iBatteryPlugin.vala
++++ b/src/common/iBatteryPlugin.vala
+@@ -76,7 +76,7 @@ namespace IndicatorKDEConnect {
+         }
+ 
+         protected void int32_signal_cb (DBusConnection con, 
+-                                        string sender, 
++                                        string? sender,
+                                         string object,
+                                         string interface, 
+                                         string signal_name, 
+@@ -87,7 +87,7 @@ namespace IndicatorKDEConnect {
+         }
+ 
+         protected void boolean_signal_cb (DBusConnection con,
+-                                          string sender,
++                                          string? sender,
+                                           string object,
+                                           string interface,
+                                           string signal_name,
+diff --git a/src/common/iDaemonPlugin.vala b/src/common/iDaemonPlugin.vala
+index 8653729..201da90 100644
+--- a/src/common/iDaemonPlugin.vala
++++ b/src/common/iDaemonPlugin.vala
+@@ -114,7 +114,7 @@ namespace IndicatorKDEConnect {
+         /*Signals Callbacks*/
+ 
+         protected virtual void device_added_cb (DBusConnection con, 
+-                                             string sender, 
++                                             string? sender,
+                                              string object,
+                                              string interface, 
+                                              string signal_name, 
+@@ -128,7 +128,7 @@ namespace IndicatorKDEConnect {
+         }
+ 
+         protected virtual void device_removed_cb (DBusConnection con, 
+-                                               string sender, 
++                                               string? sender,
+                                                string object,
+                                                string interface, 
+                                                string signal_name, 
+@@ -142,7 +142,7 @@ namespace IndicatorKDEConnect {
+         }
+ 
+         protected virtual void device_visibility_changed_cb (DBusConnection con,
+-                                                             string sender, 
++                                                             string? sender,
+                                                              string object,
+                                                              string interface, 
+                                                              string signal_name, 
+@@ -157,7 +157,7 @@ namespace IndicatorKDEConnect {
+         }
+ 
+         protected virtual void pairing_requests_changed_cb (DBusConnection con, 
+-                                                         string sender, 
++                                                         string? sender,
+                                                          string object,
+                                                          string interface, 
+                                                          string signal_name, 
+diff --git a/src/common/iDevicePlugin.vala b/src/common/iDevicePlugin.vala
+index 8570775..bad3eac 100644
+--- a/src/common/iDevicePlugin.vala
++++ b/src/common/iDevicePlugin.vala
+@@ -237,7 +237,7 @@ namespace IndicatorKDEConnect {
+ 
+         /*Callbacks */
+         protected void void_signal_cb (DBusConnection con, 
+-                                       string sender,
++                                       string? sender,
+                                        string object,
+                                        string interface,
+                                        string signal_name,
+@@ -253,7 +253,7 @@ namespace IndicatorKDEConnect {
+         }        
+ 
+         protected void string_signal_cb (DBusConnection con, 
+-                                         string sender,
++                                         string? sender,
+                                          string object,
+                                          string interface,
+                                          string signal_name,
+@@ -273,7 +273,7 @@ namespace IndicatorKDEConnect {
+         }
+ 
+         protected void boolean_signal_cb (DBusConnection con, 
+-                                          string sender,
++                                          string? sender,
+                                           string object,
+                                           string interface,
+                                           string signal_name,
+diff --git a/src/common/iSignals.vala b/src/common/iSignals.vala
+index 52c2b82..1eb390b 100644
+--- a/src/common/iSignals.vala
++++ b/src/common/iSignals.vala
+@@ -6,7 +6,7 @@
+ namespace IndicatorKDEConnect {
+     public interface ISignals : Object {
+         public virtual void void_signal_cb (DBusConnection con, 
+-                                            string sender, 
++                                            string? sender,
+                                             string object,
+                                             string interface, 
+                                             string signal_name, 
+@@ -16,7 +16,7 @@ namespace IndicatorKDEConnect {
+         }
+ 
+         public virtual void boolean_signal_cb (DBusConnection con, 
+-                                               string sender,
++                                               string? sender,
+                                                string object,
+                                                string interface,
+                                                string signal_name,
+@@ -26,7 +26,7 @@ namespace IndicatorKDEConnect {
+         }
+ 
+         public virtual void string_signal_cb (DBusConnection con, 
+-                                              string sender,
++                                              string? sender,
+                                               string object,
+                                               string interface,
+                                               string signal_name,
+@@ -36,7 +36,7 @@ namespace IndicatorKDEConnect {
+         }                               
+         
+         public virtual void int32_signal_cb (DBusConnection con, 
+-                                             string sender, 
++                                             string? sender,
+                                              string object,
+                                              string interface, 
+                                              string signal_name, 
+-- 
+2.30.1
+

Martchus commented on 2019-08-14 17:43

@ClawOfLight is right - and vala still listed as dependency and not make dependency.

ClawOfLight commented on 2019-03-05 17:06

Pretty sure that vala, meson, ninja, git should be makedepends...

pingplug commented on 2018-11-17 10:42

  1. do not install to system when building package
  2. do not include ${pkgdir} in prefix when configure (@jonathon)
  3. do not build source code in package() function

adding DESTDIR="${pkgdir}" before ninja install can help

jonathon commented on 2018-11-16 20:49

The last change broke packaging as it's trying to install to /usr during package(). This diff will fix it (and tidy up a couple of other things):

(updated as per @pingplug above)

diff --git a/PKGBUILD b/PKGBUILD
index 4d5517b..631e0de 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -13,7 +13,7 @@ conflicts=('indicator-kdeconnect')
 provides=('indicator-kdeconnect')
 depends=('libappindicator-gtk3' 'kdeconnect' 'vala' 'python-requests-oauthlib' 'python-gobject' 'libgee')
 makedepends=('git' 'meson' 'ninja')
-source=('git://github.com/bajoja/indicator-kdeconnect.git')
+source=('git+https://github.com/bajoja/indicator-kdeconnect.git')
 md5sums=('SKIP')

 pkgver() {
@@ -21,11 +21,13 @@ pkgver() {
   printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
 }

+build() {
+  mkdir build && cd build
+  meson ../$_gitname --prefix=/usr  --libdir=/usr/lib
+  ninja
+}
+
 package() {
-  cd indicator-kdeconnect
-  mkdir build
   cd build
-  meson .. --prefix=/usr/  --libdir=/usr/lib/
-  ninja
-  ninja install
+  DESTDIR=$pkgdir ninja install
 }

ClawOfLight commented on 2018-11-13 09:34

Missing dependency: libgee

eskimod commented on 2018-11-13 00:24

I think the install step is missing something because no files are actually installed (checked with pacman -Ql).

zufallsheld commented on 2018-11-11 14:40

Thanks @jonathon, fixed!

jonathon commented on 2018-11-11 14:25

From commit a15c091fc5c265db5f7091ae20b0ac39ec58db06 upstream have switched from cmake to meson

zufallsheld commented on 2017-05-07 10:46

Thanks, updated.