Arch Linux User Repository

The pkgver value should not have the "v" in it, that needs to be striped out in the pkgver() function.

Upstream url has been updated, thanks.

Please don't "version bump" -git or other VCS based packages! Only update when there actual changes to the build process other than the version which will be regenerated at build time anyway.

Second the call to change the upstream to follow serxxx's fork. See discussion on gotop and nate gotop-bin is also moved over too.

Updated pkgbuild: https://github.com/FabioLolix/PKGBUILD-AUR_fix/blob/master/g/gotop-git/PKGBUILD

Hi, would it be possible to change the source of this package to the fork maintained by @serxxx ?

https://github.com/xxxserxxx/gotop

This issue explains the recent developments with gotop:

https://github.com/cjbassi/gotop/issues/187

Also, the other two gotop packages have already been changed to point to serxxx's fork, if that has any bearing on your decision.

Hi @m3thodic,

I've added a desktop entry and icon so that it can be run from a DE directly. Here's the patch, you can apply it with git am 1-gotop-git.patch.

I've also updated the git revision in a seperate patch.

@egrupled Thanks again. Should be fixed now. I applied the same changes that I described in the gotop AUR package.

There are couple issues with the current PKGBUILD:

1. It creates persistent ~/go dir (with default GOPATH) and download all dependencies there. Moreover files in that dir are set as read-only.

2. It doesn't honor LDFLAGS

Below is example which fixes this issue:

1. It sets GOPATH to temporary directory under build dir.

2. It take LDFLAGS into account, also strips build path for reproducibility[1].

3. It makes temporary GOPATH writable which allows for clean up.

[1] https://wiki.archlinux.org/index.php/Go_package_guidelines#Flags_and_build_options

Please consider adopting those changes.

build() {
  cd "$srcdir/$pkgname"
  export GOPATH="$srcdir/gopath"
  go build \
  -gcflags "all=-trimpath=${PWD}" \
  -asmflags "all=-trimpath=${PWD}" \
  -ldflags "-extldflags ${LDFLAGS}"
}

package() {
  export GOPATH="$srcdir/gopath"
  install -Dm755 "$srcdir/$pkgname/gotop" "$pkgdir/usr/bin/gotop"
  chmod -R 644 "$GOPATH"
}

@egrupled thanks for the heads up, PKGBUILD has been updated.