Arch Linux User Repository

Done!

This package started failing to build for me since bison was updated to 3.7 with the following error message:

DataFilter.tab.c:152:10: fatal error: DataFilter.tab.h: No such file or directory

There is an upstream pull request for this (https://github.com/GoldenCheetah/GoldenCheetah/pull/3628) however a dev has indicated that this is not going to be merged anytime soon since this does not affect their CI:

18.04 uses bison 3.04, 20.04 is 3.5-- bottom line here is that for the most part, and for some time to come, this is pretty much a non-issue

Thus I have integrated the pull request as patch into the package and it solves the build issue for me. Here are my modification to the PGKBUILD:

diff --git a/PKGBUILD b/PKGBUILD
index d240ef7..bb798c7 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -14,14 +14,23 @@ optdepends=('vlc' 'srmio' 'libftd2xx' 'libkml' 'libical' 'libusb-compat' 'libsam
 options=('!strip' '!buildflags' 'staticlibs')
 conflicts=('golden-cheetah-rc' 'golden-cheetah-dev' 'golden-cheetah')
 source=('golden-cheetah::git+https://github.com/GoldenCheetah/GoldenCheetah.git'
-GoldenCheetah.desktop gc.png gcconfig.pri)
-md5sums=('SKIP' af5e5a4376ee82ccfb69aa455b35a2d9 e1fb382b4a7316da1ffd435e45e50c4a 'SKIP')
+GoldenCheetah.desktop gc.png gcconfig.pri 'https://patch-diff.githubusercontent.com/raw/GoldenCheetah/GoldenCheetah/pull/3628.patch')
+md5sums=('SKIP'
+         'af5e5a4376ee82ccfb69aa455b35a2d9'
+         'e1fb382b4a7316da1ffd435e45e50c4a'
+         'cd5e1b1ab5e891d82f18fb33d3c6d34d'
+         '08222368b11f4fe8ef7f57ae0384a9da')

 pkgver() {
   cd "${srcdir}/golden-cheetah"
   printf "%s" "$(git describe --long --tags | sed 's/\([^-]*-\)g/r\1/;s/-/./g')"
 }

+prepare() {
+  cd "${srcdir}/golden-cheetah/"
+  patch --forward --strip=1 --input="${srcdir}/3628.patch"
+}
+
 build() {
   cd "${srcdir}/golden-cheetah/"

Also following that logic it should also include binutils in makedepends for stripping package and maybe even more.

Without these dependencies the PKGBUILD would be smaller, you will say that couple bytes is nothing, but if every of 60k+ packages would list those it would make noticeable difference.

@micwoj92 oke I found the section in the wiki: https://wiki.archlinux.org/index.php/Arch_User_Repository#Getting_started

But I still don't get it why that is a problem. If users don't have it installed for some weird reason then it will still work. This also makes clear that golden-cheetah requires flex and bison for example.

I think this discussion is more about taste than practical reasons, so I suggest to just leave it as it is. Are there practical reasons?

This is not my point, my point is that you should not list packages that are in base-devel. Someone wants to use aur? Install base-devel first. end.

@micwoj92 these dependencies are in "makedepends" which means they can be removed after building and installing

Hello, could you remove bison, flex, gcc, make and pkgconf from depends? These are in base-devel.

@pmorales done :)

Hi! I was unable to compile until I manually install qt5-webengine. Please add it as a dependency. Thanks!