Package Details: gnu-poke-git r3747.48148bc2-1

Git Clone URL: https://aur.archlinux.org/gnu-poke-git.git (read-only, click to copy)
Package Base: gnu-poke-git
Description: Interactive, extensible editor for binary data.
Upstream URL: http://www.jemarch.net/poke.html
Licenses: GPL3
Provides: poke
Submitter: tleydxdy
Maintainer: Arvedui
Last Packager: tleydxdy
Votes: 2
Popularity: 1.43
First Submitted: 2020-03-30 08:34
Last Updated: 2020-11-18 14:44

Required by (0)

Sources (3)

Latest Comments

Arvedui commented on 2020-11-18 14:33

Yea, just disown it it. I would be happy to take over :)

tleydxdy commented on 2020-11-18 14:12

actually I haven't been using this for a while now. It should be better anyone that actually uses this wants to adopt it. Should I just drop it then?

Will apply the patches tho

Arvedui commented on 2020-11-18 14:02

Hi, thanks for creating this package. I noticed a few issues in your PKGBUILD though

  1. A package containing compiled stuff should not have an arch of any
  2. The runtime dependencies gettext and json-c are missing
  3. The check time dependency dejagnu
  4. The git repository has submodules which are no tracked by makepkg
  5. configure and friends should be executed in prepare, not build
  6. CFLAGS and LDFLAGS are not passed to configure

Here is a patch that fixes all those problems, fell free to just apply that.

diff --git a/PKGBUILD b/PKGBUILD
index 1c298fc..777aaf4 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -1,31 +1,50 @@
 # Maintainer: Yunxiang Li <shironeko@waifu.club>

 pkgname=gnu-poke-git
-pkgver=r3085.bb2998d4
+pkgver=r3747.48148bc2
 pkgrel=1
 pkgdesc="Interactive, extensible editor for binary data."
-arch=('any')
+arch=(i686 x86_64 armv6h armv7h aarch64)
 url="http://www.jemarch.net/poke.html"
 license=('GPL3')
-depends=('gc' 'readline')
-makedepends=('help2man' )
-checkdepends=()
+depends=('gc' 'readline' 'gettext' 'json-c')
+makedepends=('help2man' 'git')
+checkdepends=('dejagnu')
 optdepends=()
 provides=('poke')
-source=("${pkgname}::git+https://git.savannah.gnu.org/git/poke.git")
-sha256sums=('SKIP')
+source=("
+    ${pkgname}::git+https://git.savannah.gnu.org/git/poke.git"
+    gnulib::git://git.sv.gnu.org/gnulib
+    jitter::git+http://git.ageinghacker.net/jitter
+    )
+sha256sums=(
+    'SKIP'
+    'SKIP'
+    'SKIP'
+    )

 pkgver() {
-    cd "$pkgname"
+    cd "${pkgname}"
     printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
 }

-build() {
+prepare() {
     cd "${pkgname}"
+    git submodule init gnulib
+    git config submodule.gnulib.url "${srcdir}/gnulib"
+    git submodule init jitter
+    git config submodule.jitter.url "${srcdir}/jitter"
+    git submodule update

     ./bootstrap --skip-po
     mkdir build && cd build
-    ../configure --prefix=/usr
+    ../configure --prefix=/usr CFLAGS="${CFLAGS}" LDFLAGS="${LDFLAGS}"
+
+}
+
+build() {
+    cd "${pkgname}/build"
+
     make
 }