Package Details: gnome-shell-extension-cast-to-tv 15-1

Git Clone URL: https://aur.archlinux.org/gnome-shell-extension-cast-to-tv.git (read-only, click to copy)
Package Base: gnome-shell-extension-cast-to-tv
Description: Cast files to your Chromecast or other devices over local network
Upstream URL: https://github.com/Rafostar/gnome-shell-extension-cast-to-tv
Licenses: GPL2
Submitter: 314eter
Maintainer: 314eter (peippo)
Last Packager: peippo
Votes: 4
Popularity: 0.048805
First Submitted: 2019-01-08 15:56
Last Updated: 2020-04-30 08:10

Latest Comments

1 2 3 Next › Last »

yochananmarqos commented on 2020-04-30 17:46

I see that you moved the npm install to build()

Yes, as we're not directly installing a tarball as in the guideline example. Always build first outside of the fakeroot environment if possible to avoid numerous issues.

nodejs modules...have no place inside /usr/share/gnome/extensions

Good point. When I have time, I'll see what can be done about that.

You don’t implement the safeguards recommended in the package guidelines

They're not necessary as the node modules are not being directly installed to $pkgdir.

peippo commented on 2020-04-30 08:10

@yochananmarqos: could you explain the changes you made?

I see that you moved the npm install to build() (the packaging guidelines at https://wiki.archlinux.org/index.php/Node.js_package_guidelines recommend to have that in install()) I think ultimately our goal should rather be to have all nodejs modules as dependencies, outside of the PKGBUILD, since they have no place inside /usr/share/gnome/extensions (namcap is in fact complaining about this).

Then you have a slightly different strategy for selectively installing files to ${pkgdir}: I move certain files vs. you move everything (using a second call to make install), then delete certain files. I argue that my explicit moving files is the more secure way, even if it might mean potentially having to update the PKGBUILD if a new upstream version introduces big changes.

You don’t implement the safeguards recommended in the package guidelines, i.e. making sure that npm-installed files have the correct permissions.

But I have to admit that my PKGBUILD did not install the README.md, something I will correct immediately (note that the license file is not necessary since GPL2 is a standard license, contained in /usr/share/licenses/common/)

Thanks also for the draft PKGBUILDS for the add-ons to the extension! I see @Rafostar making tremendous advances, with the addons taking shape quickly.

yochananmarqos commented on 2020-04-30 03:17

Improved PKGBUILD.

Preliminary PKGBUILD's for the add-ons. No guarantee the addons themselves will function.

peippo commented on 2020-04-09 07:34

@andrew-wja: The dependency should rather go into the package that serves the desktop streaming add-on. I don’t think there is any at the moment. Given its early-alpha stage I personally don’t want to invest time into packaging the add-on yet.

andrew-wja commented on 2020-04-07 15:08

The desktop streaming addon will fail to work unless gst-plugins-ugly is available, so it probably makes sense to add that as a dependency of this package

peippo commented on 2020-03-28 15:54

Note that the current version 12 does not function in Gnome 3.36. @Rafostar implemented changes upstream, but there’s no new release yet. For the time being, you can use gnome-shell-extension-cast-to-tv-git.

peippo commented on 2020-03-16 08:54

@Rafostar: That’s great! I wanted to suggest to add another patch to hide the settings dialog’s tab (only for the Arch build; I don’t know which distribution is your primary one, and I think you have a right to optimize it for that) If you feel comfortable with having these changes inside the upstream Makefile, of course that’s fine with me, but we could also implement that on a PKGBUILD level, so your upstream code can stay clean.

Rafostar commented on 2020-03-13 15:13

@peippo As a solution for broken (and unnecessary) extension prefs terminal and nautilus extension switch on Arch, I did a small change to Makefile and prefs code that will simply not create them in prefs window (probably best solution). Your script and patch can remain as they are without any changes. Thanks for maintaining the Arch build.

Rafostar commented on 2020-03-13 13:33

The 777 permissions is a solution that originally 314eter came up with. I agree that it is not a safe workaround, but without something like that the build-in terminal in prefs is broken. Having install button broken is not a good idea too (quite misleading).

Copying nautilus extension script manually also breaks the enable nautilus switch in settings. Is it absolutely required to force enable this via copy instead of using enable switch that creates a symlink in ~.local after install on Arch?

peippo commented on 2020-03-13 12:27

I think for overall purposes, it’s convenient that your Makefile can install to local (~.local/) directories, and patch supplied here makes the Makefile adhere to Arch packaging guidelines without changes to your source code.