Package Details: github-cli-bin 0.10.1-1

Git Clone URL: https://aur.archlinux.org/github-cli-bin.git (read-only, click to copy)
Package Base: github-cli-bin
Description: The official GitHub CLI - binary
Upstream URL: https://github.com/cli/cli
Keywords: gh github
Licenses: MIT
Conflicts: github-cli
Provides: github-cli
Submitter: ZimbiX
Maintainer: ZimbiX
Last Packager: ZimbiX
Votes: 11
Popularity: 1.60
First Submitted: 2020-02-03 07:02
Last Updated: 2020-06-24 17:49

Dependencies (2)

Required by (0)

Sources (1)

Latest Comments

Kr1ss commented on 2020-05-12 12:21

Ah okay...

The suggestion was to include the upstream changelog (CHANGELOG.md), which is provided in the source tarball, anyways. The whole point is that this would enable the use of the pacman -Qc facility.

Looks like there's a very little number of packages including this, even in the official repositories, so I guess it's not that impoortant.

ZimbiX commented on 2020-05-12 12:15

@Kr1ss I've finally gotten around to addressing your previous feedback - thanks for that, by the way.

I don't quite understand the point of maintaining a changelog file. I've opted to leave it out, since my change messages are tracked in Git. I could generate it from the Git log, but that seems like unnecessary duplication. Plus it makes the workflow for adding a new commit a bit wonky; where, after committing, I'd need to then regenerate the changelog and amend it into the commit.

Kr1ss commented on 2020-05-12 11:48

Thank you for reacting so quickly.

Cheers !

ZimbiX commented on 2020-05-12 11:15

@Kr1ss Oh wow, sorry; I don't know how I missed that! I updated the version from my phone while bleary-eyed this morning =S I'll fix it now

Kr1ss commented on 2020-05-12 09:38

Hello @ZimbiX,

just wondering if you intentionally dropped the shell completion functions. If not, could you pls include

  install -Dm644 <(bin/gh completion -s bash) "$pkgdir/usr/share/bash-completion/completions/gh"
  install -Dm644 <(bin/gh completion -s fish) "$pkgdir/usr/share/fish/vendor_completions.d/gh.fish"
  install -Dm644 <(bin/gh completion -s zsh)  "$pkgdir/usr/share/zsh/site-functions/_gh"

to the package() function, in order to add it back ?

Thx a lot !

Kr1ss commented on 2020-02-06 14:07

Hey @ZimbiX, thx a lot for packaging this !

Quote:

Any feedback welcome! =)

Some minor suggestions :

  1. Maybe you could install the documentation as well ? install -Dm644 "gh_${pkgver}_linux_amd64"/*.md -t"$pkgdir/usr/share/doc/github-cli/"
  2. The Arch Build System does allow you to include a changelog into the package, which can then be queried from the installed package by pacman -Qc <pkgname>. There's a PKGBUILD variable for this (just add changelog=CHANGELOG.md); you don't need to include the file in the source array, but it needs to be copied into the AUR folder (next to the PKGBUILD).
  3. Have you thought about adding a (hard or at least optional) dependency to git ?

Again, thank you very much.

Cheers !

ZimbiX commented on 2020-02-04 07:46

Thanks for the tips, @glitsj16! =) I've updated it to incorporate them (and provide the new version, 0.5.3)

glitsj16 commented on 2020-02-03 16:13

Thanks for offering this in the AUR. Remarks to improve the PKGBUILD: - pkgdesc should add '- binary' to inform users this is a binary instead of a compiled version; - future-proof by adding 'conflicts=(github-cli)' and 'provides=(github-cli)'; - license should be installed as 644, not 655.