Arch Linux User Repository

@besc: Ah, forgot about that, thanks.

The PKGBUILD is missing the python-qtpy dependency, python-pyqt5 is not sufficient. Looks like the problem was introduced by the recent NO_VENDOR_LIBS=1 change.

I got a lot of test errors trying to update today:

===================================== short test summary info ======================================
FAILED test/browse_model_test.py::ClassicModelTestCase::test_unstage_paths - AssertionError: 128 ...
FAILED test/browse_model_test.py::ClassicModelTestCase::test_unstage_paths_subdir - AssertionErro...
FAILED test/gitcmds_test.py::GitCmdsTestCase::test_all_refs - AssertionError: 128 != 0
FAILED test/gitcmds_test.py::GitCmdsTestCase::test_all_refs_split - AssertionError: 128 != 0
FAILED test/gitcmds_test.py::GitCmdsTestCase::test_branch_list_local - AssertionError: 128 != 0
FAILED test/gitcmds_test.py::GitCmdsTestCase::test_branch_list_remote - AssertionError: 128 != 0
FAILED test/gitcmds_test.py::GitCmdsTestCase::test_tag_list - AssertionError: 128 != 0
FAILED test/gitops_test.py::ColaBasicGitTestCase::test_git_commit - AssertionError: 128 != 0
FAILED test/main_model_test.py::MainModelTestCase::test_local_branches - AssertionError: 128 != 0
FAILED test/main_model_test.py::MainModelTestCase::test_remote_branches - AssertionError: 128 != 0
FAILED test/main_model_test.py::MainModelTestCase::test_tags - AssertionError: 128 != 0
11 failed, 169 passed in 4.12s

@MarcinWiezorek: It turns out make html is redundant since make doc already makes all documentation.

@yochananmarqos I've added you as co-maintainer. Sorry it took so long, I must've missed your reply.

@MarcinWieczorek:

Do you want to co-maintain so you can push the changed yourself?

Sure.

USE_ENV_PYTHON. Why would we need it?

Otherwise the shebangs are changed to #!/usr/bin/python instead of #!/usr/bin/env python. It's best not to hardcode the path in case people have multiple versions of Python installed.

@yochananmarqos Thank you for adding so much upgrades. Do you want to co-maintain so you can push the changed yourself? I totally agree with all changes, but I'm unsure about the first one, USE_ENV_PYTHON. Why would we need it?

New additions to my PKGBUILD:

Build environment variables:

• USE_ENV_PYTHON=1: See Installation
• GIT_COLA_NO_PRIVATE_LIBS=1: See Packaging notes
• GIT_COLA_NO_VENDOR_LIBS=1: See Packaging notes
• PYTHONHASHSEED=0: See Python package guidelines

Optional dependency: - python-send2trash: See Additives

Added check() with unit tests

By the way, I see no reason to disable makeflags.

@MarcinWieczorek: It's working fine, thanks.

@yochananmarqos please verify new version ;)