Arch Linux User Repository

I made some changes in the PKGBUILD I added rustup as dependence to make things easier.

https://gist.github.com/reinaldoossuna/64716be202fb287f5deb6a5448556799

I've created a modified version of the PKGBUILD here.

The changes along with the reasoning are as follows:

• makedepends was changed to use rustup instead of cargo to conform to the build instructions
• build() and package() were changed to conform to the arch rust packaging guidelines, along with some changes for future proofing as the project may create more files later on

• pkgver() was changed to conform to the arch vcs package guidelines.

• Unused variables were removed to cleanup the script.

• namcap seems to have no complaints about dependencies so I didnt touch that.

I have a question about whether the toolchain override (i.e the +nightly flag) should be present in the PKGBUILD or should it be left upto the rust-toolchain file in the repo (i.e the default). @elkowar and @McFranko some input would be appreciated.

Something should also be done to handle systems with wayland or specify that this is for xorg in the package description.

@earlybird

I had the same error and this guide helped me: https://ma.ttias.be/cargo-no-such-subcommand-nightly/

Basically I installed rustup (replacing rust), then ran rustup toolchain install nightly. Then the installation ran without problems.

Can not build it - message is error: no such subcommand: +nightly ==> ERROR: A failure occurred in build().

Can you assist?

Hi, McFranko! Thanks for taking others' suggestions into account.

Please review the Rust packaging guidelines [1] and general packaging guidelines [2] so as to better the quality standards of your package. This will help all users of your package, so it's important that you review your PKGBUILD as there's a lot that can be improved.

Thanks!

[1] https://wiki.archlinux.org/index.php/Rust_package_guidelines [2] https://wiki.archlinux.org/index.php/Arch_package_guidelines

If the nightly toolchain is necessary, I recommend using rust-nightly as make dependency.

I'd not used rust before and had a little trouble getting this to install. For me this package installed the rust package as a makedepends, but then failed to build eww with error E0554: feature attributes are only allowed on the nightly release channel.

Instead (following archwiki) I installed rustup from the repos and ran "rustup toolchain install nightly". Then I was able to build eww.

I'm not sure if the package maintainer can do anything about this, but I hope it helps someone else.

You should use the install command instead of the mkdir and then the mv command. Also, the pkgver errors:

==> Starting pkgver()...
fatal: No names found, cannot describe anything.

I have updated the PKGBUILD with your suggestions

A couple issues with this package:

• The license is simply WRONG - Eww is licensed under MIT, not GPL

• Non-rust dependencies like gtk are missing from the list of dependencies

• provides should contain eww

• The pkgver() format is kind of dumb, as it does not indicate actual order. Instead, the suggested approach of using rREVISION_NUMBER should be followed - the arch wiki specifies how to implement that.

• The PKGBUILD currently builds eww in debug profile. Instead, it should be built in release mode.