Package Details: dxvk-winelib 1.6.1-6

Git Clone URL: https://aur.archlinux.org/dxvk-winelib.git (read-only, click to copy)
Package Base: dxvk-winelib
Description: Vulkan-based implementation of D3D9, D3D10 and D3D11 for Linux / Wine, Winelib version
Upstream URL: https://github.com/doitsujin/dxvk
Licenses: zlib/libpng
Conflicts: d9vk, dxvk
Provides: d9vk, dxvk, dxvk=1.6.1
Submitter: nicman23
Maintainer: loathingkernel
Last Packager: loathingkernel
Votes: 3
Popularity: 0.002960
First Submitted: 2019-10-05 05:28
Last Updated: 2020-11-02 00:40

Latest Comments

« First ‹ Previous 1 2 3 Next › Last »

FFY00 commented on 2019-12-04 09:55

It does not, as I explained in my previous comment. The wiki should be improved yes but my point is still valid.

Just a final comment, you can do this if you want, that is fine, just not put it in the AUR. It is not how things work and Archlinux.

nicman23 commented on 2019-12-04 09:55

and you know that packages like https://aur.archlinux.org/packages/wine-staging-pba have a LOT more patches than mine that do not in fact make it compile.

nicman23 commented on 2019-12-04 09:51

look you might disagree with me but the way it is stated it does indeed comply with all guidelines so you are in the wrong. either update the wiki or stop that.

FFY00 commented on 2019-12-04 09:47

Yes, I do. Small patching is allowed in prepare(), not this.

From https://wiki.archlinux.org/index.php/Creating_packages#prepare():

With this function, commands that are used to prepare sources for building are run, such as patching.

I agree it is not that clear in this case but still, it says prepare() is used to prepare the sources for building. Ex. setting up submodules, fixing the build system, etc. You are not preparing the sources for the build step, they compile just fine. What you are doing is applying a bunch of commits (aka checking out) effectively transforming the source in other version. That's not how this should work.

nicman23 commented on 2019-12-04 09:38

you do realize that at the point of git fetch --tags the origin is the local folder and not a remote server. checking out a commit is the same thing as applying a patch with -R on the already downloaded code. this is not conjecture or opinion. it is a fact. i am not updating the source. i am reverse patching it which is the actual stated function of prepare(). if there is indeed a policy/ rule against that, you have not cited it.

if you do go ahead with orphaning, i request that you delete it instead.

FFY00 commented on 2019-12-04 09:25

It's not metadata as it will update the sources. When you checkout a commit the tree for that commit will be built, you are updating the sources.

This is the last warning, if you keep doing this I will orphan the package.

nicman23 commented on 2019-11-16 12:03

i am not getting/ updating sources. metadata are not sources. if anything i am downgrading master to a stable tag, which itself is git running patch -R

FFY00 commented on 2019-11-16 09:08

What do you mean?

With this function, commands that are used to prepare sources for building are run, such as patching.

This is the place to prepare sources not to fetch/update them, like you are doing. The sources in sources are fetched and then prepare will move files, apply patches, etc. to make them suitable for the build process. You are updating the sources, when you should be preparing them.

nicman23 commented on 2019-11-16 07:57

As it is a custom license (it's not in the licenses package) it needs to be installed to the filesystem.

done

Don't submit the package then, it clearly does not follow the arch packaging guidelines which are to be used here in the AUR.

to be honest i cannot find anything in the wiki that the package breaks.. https://wiki.archlinux.org/index.php/Creating_packages#prepare() clearly states that you can patch the sources on the prepare function - which is what is git is, even if it is a reverse patch. It might be weird that nobody else is doing it but being novel is not breaking the rules. as for pkgver(), it also breaks no rules, as it just describes the source with the correct tag.

conflicts and provides

can you please help me with those. i edited them but i think this is not want you meant.

FFY00 commented on 2019-11-15 22:41

Oh, I also missed the license issue. As it is a custom license (it's not in the licenses package) it needs to be installed to the filesystem.