I'd just like to say thank fucking christ for this package being cleaned up.
Search Criteria
Package Details: dxvk-winelib 1.6-1
| Git Clone URL: | https://aur.archlinux.org/dxvk-winelib.git (read-only, click to copy) |
|---|---|
| Package Base: | dxvk-winelib |
| Description: | Vulkan-based implementation of D3D9, D3D10 and D3D11 for Linux / Wine, Winelib version |
| Upstream URL: | https://github.com/doitsujin/dxvk |
| Licenses: | |
| Conflicts: | |
| Provides: | |
| Submitter: | nicman23 |
| Maintainer: | loathingkernel |
| Last Packager: | loathingkernel |
| Votes: | 3 |
| Popularity: | 1.13 |
| First Submitted: | 2019-10-05 05:28 |
| Last Updated: | 2020-03-20 18:18 |
Dependencies (9)
- bash (bash-devel-git, bash-devel-static-git)
- lib32-vulkan-icd-loader
- vulkan-icd-loader
- wine>=4.0rc1 (wine-unity3d-git, wine-ivb, wine-vulkan-git, wine-staging-pba, wine-git, wine-stable-next, wine-stable, wine-valve-git, wine-staging-git, wine-staging)
- git (git-git) (make)
- glslang (glslang-git) (make)
- ninja (ninja-git, ninja-kitware, ninja-samurai, ninja-mem) (make)
- wine (wine-unity3d-git, wine-ivb, wine-vulkan-git, wine-staging-pba, wine-git, wine-stable-next, wine-stable, wine-valve-git, wine-staging-git, wine-staging) (make)
- meson>=0.43 (meson-git) (make)
Required by (0)
Sources (4)
katt commented on 2020-01-09 20:32
loathingkernel commented on 2019-12-16 19:50
This package contains three patches which are not applied by default. Feel free to read the documentation inside the PKGBUILD on what they do and how to enable them.
Don't report issues with these patches enabled to the dxvk creator before posting here. If you do, please be aware that they will probably close your issue nevertheless.
FFY00 commented on 2019-12-04 10:22
redownloading the whole source when you can just git fetch is bad and wasteful. this is the whole point for it to be honest.
You can get makepkg to checkout a specific tag or commit :). Look at my changes.
The point is, you do it in the sources array, not in prepare. And you don't do it automatically, you bump pkgver.
nicman23 commented on 2019-12-04 10:17
look you need to fix this.
You are changing the version
this needs to be in the guidelines. i get that.
still i think this should be something in makepkg. redownloading the whole source when you can just git fetch is bad and wasteful. this is the whole point for it to be honest.
FFY00 commented on 2019-12-04 10:10
Actually I am sorry, 11 patches. The pba patches (9) and 2 extra pacthes to fix bugs. This is actually not a good package to be using as en example because one of the sources is missing.
then where are they listed
They are in the wie-pba repo, which is missing now.
Either way, the purpose of those patches is totally different than the purpose of yours. You are changing the version, wine-staging-pba is provides wine-staging patched with the wine-pba patches.
nicman23 commented on 2019-12-04 10:02
then where are they listed
FFY00 commented on 2019-12-04 10:01
wine-staging-pba patches wine-staging to add pba, not to effectively change the version. Also, 9 patches are not a LOT more but OK.
The rules are not arbitrary, please read my comment.
nicman23 commented on 2019-12-04 09:57
then the rules are arbitrary and you are just making them up. got it.
FFY00 commented on 2019-12-04 09:55
It does not, as I explained in my previous comment. The wiki should be improved yes but my point is still valid.
Just a final comment, you can do this if you want, that is fine, just not put it in the AUR. It is not how things work and Archlinux.
nicman23 commented on 2019-12-04 09:55
and you know that packages like https://aur.archlinux.org/packages/wine-staging-pba have a LOT more patches than mine that do not in fact make it compile.
Pinned Comments
loathingkernel commented on 2019-12-16 19:50
This package contains three patches which are not applied by default. Feel free to read the documentation inside the PKGBUILD on what they do and how to enable them.
Don't report issues with these patches enabled to the dxvk creator before posting here. If you do, please be aware that they will probably close your issue nevertheless.