Arch Linux User Repository

hunk failed at #34

@MCWertGaming

The problem is in the code-liveshare.diff there's a conflict on the line that's supposed to be patched, the workaround I've come up with is to edit the PKGBUILD, in the prepare function comment out or delete the line 67:

patch -p1 -i "${srcdir}/code-liveshare.diff"

and add the next line instead:

sed -i '39i "ms-vsliveshare.vsliveshare",' product.json

Please change to nodejs-lts-erbium as it's the latest supported nodejs lts version.

Visual studio code is not compiling on latest commit, i get this error:

==> Starting prepare()...
patching file product.json
patching file product.json
Hunk #1 FAILED at 19.
1 out of 1 hunk FAILED -- saving rejects to file product.json.rej
==> ERROR: A failure occurred in prepare().
    Aborting...

[13:52:36] Starting optimize-vscode ...
There is a dependency cycle between 'vs/workbench/contrib/remote/browser/remote' and 'vs/workbench/contrib/remote/browser/tunnelView'. The cyclic path follows:
vs/workbench/contrib/remote/browser/remote => 
vs/workbench/contrib/remote/browser/tunnelView => 
vs/workbench/contrib/remote/browser/remote
[13:52:41] 'vscode-linux-x64-min' errored after 5.53 min
[13:52:41] Error: Cannot do topological sort on cyclic graph, remaining nodes: ===anonymous2===,vs/workbench/workbench.desktop.main,vs/workbench/workbench.common.main,vs/workbench/contrib/remote/browser/remote,vs/workbench/contrib/remote/browser/tunnelView
    at topologicalSort (/run/media/user/user/yay/code-git/src/vscode/build/lib/bundle.js:460:15)
    at emitEntryPoints (/run/media/user/user/yay/code-git/src/vscode/build/lib/bundle.js:81:27)
    at Object.loader (/run/media/user/user/yay/code-git/src/vscode/build/lib/bundle.js:62:31)
    at Function.Module._invokeFactory (evalmachine.<anonymous>:1036:41)
    at Module.complete (evalmachine.<anonymous>:1046:36)
    at ModuleManager._onModuleComplete (evalmachine.<anonymous>:1663:20)
    at ModuleManager._onModuleComplete (evalmachine.<anonymous>:1675:30)
    at ModuleManager._onModuleComplete (evalmachine.<anonymous>:1675:30)
    at ModuleManager._onModuleComplete (evalmachine.<anonymous>:1675:30)
    at ModuleManager._onModuleComplete (evalmachine.<anonymous>:1675:30)
    at ModuleManager._onModuleComplete (evalmachine.<anonymous>:1675:30)
    at ModuleManager._onModuleComplete (evalmachine.<anonymous>:1675:30)
    at ModuleManager._onModuleComplete (evalmachine.<anonymous>:1675:30)
    at ModuleManager._onModuleComplete (evalmachine.<anonymous>:1675:30)
    at ModuleManager._onModuleComplete (evalmachine.<anonymous>:1675:30)
    at ModuleManager._onModuleComplete (evalmachine.<anonymous>:1675:30)

*** NOTE: If the build failed due to running out of file handles (EMFILE),
*** you will need to raise your max open file limit.
*** You can check this for more information on how to increase this limit:
***    https://ro-che.info/articles/2017-03-26-increase-open-files-limit
Error making: code-git
[user@archlinux code-git]$ 

Edit: Package now compiles fine for me. Thanks for making it working again!

Anyone trying to install VSCode for aarch64 (Devices such as Pinebook Pro) should look at the Headmelted VSCode package in the AUR. It has working binaries for aarch64.

What would be the recommended course of action for aarch64 considering electron6 isn't available?

Hi everyone!

For anyone that want to install it on aarch64 (like Pinebook Pro or Pi4) you need to edit PKGBUILD at line 9 to add 'aarch64' as follows:

arch=('i686' 'x86_64' 'armv7h' 'aarch64')

And then add this code to the case statement at line 38:

    aarch64)
        _vscode_arch=arm64
        ;;

If you have less than 8GB RAM on your system (like on Pinebook Pro or Pi4) then make sure to add a swap partition or swap file to increase your RAM before compiling.

Thank you very much @Zrax for creating this package, it has been incredibly useful to me and so many people!

For everyone like me that prefer a patch file, here is the Git patch:

diff --git a/PKGBUILD b/PKGBUILD
index 282fdd7..c692486 100644
--- a/PKGBUILD
+++ b/PKGBUILD
@@ -6,7 +6,7 @@ pkgname=code-git
 pkgdesc='The Open Source build of Visual Studio Code (vscode) editor - git latest'
 pkgver=1.38.0.r1831.g3d3202804b
 pkgrel=1
-arch=('i686' 'x86_64' 'armv7h')
+arch=('i686' 'x86_64' 'armv7h' 'aarch64')
 url='https://github.com/microsoft/vscode'
 license=('MIT')
 depends=('electron' 'libsecret' 'libx11' 'libxkbfile' 'ripgrep')
@@ -35,6 +35,9 @@ case "$CARCH" in
     armv7h)
         _vscode_arch=arm
         ;;
+    aarch64)
+        _vscode_arch=arm64
+        ;;
     *)
         # Needed for mksrcinfo
         _vscode_arch=DUMMY

I still get the same node-gyp error with electron6 pacman package (any node_modules/* module, e. g. native-watchdog, native-keymap, ...). I tried it with nodejs-lts-dubnium and nodejs.

Edit: Now it's

[20:16:18] 'vscode-linux-x64-min' errored after 14 min
[20:16:18] Error: Missing Electron option: version.
    at electron (/run/media/user/user/yay/code-git/src/vscode/node_modules/gulp-atom-electron/src/index.js:65:9)
    at /run/media/user/user/yay/code-git/src/vscode/build/gulpfile.vscode.js:271:10
    at /run/media/user/user/yay/code-git/src/vscode/build/lib/task.js:44:28
    at new Promise (<anonymous>)
    at _doExecute (/run/media/user/user/yay/code-git/src/vscode/build/lib/task.js:33:12)
    at _execute (/run/media/user/user/yay/code-git/src/vscode/build/lib/task.js:24:11)
    at vscode-linux-x64-min-ci (/run/media/user/user/yay/code-git/src/vscode/build/lib/task.js:63:19)
    at async _execute (/run/media/user/user/yay/code-git/src/vscode/build/lib/task.js:24:5)
    at async result (/run/media/user/user/yay/code-git/src/vscode/build/lib/task.js:63:13)
    at async _execute (/run/media/user/user/yay/code-git/src/vscode/build/lib/task.js:24:5)
    at async vscode-linux-x64-min (/run/media/user/user/yay/code-git/src/vscode/build/lib/task.js:63:13)

I don't know anything about the electron provided by npm... I meant using the version provided by arch (e.g. by downloading from https://archive.archlinux.org/packages/e/electron/ ). When I tested the latest 6.1 version from there yesterday, it built correctly.