Arch Linux User Repository

I realized my previous, deleted, post contained a typo. As well, the package as is provides no documentation nor example configuration file, a major flaw.

This patch fixes the build and adds documentation to be installed in the correct place in the system.

--- PKGBUILD    2021-06-10 14:31:25.515118942 -0500
+++ PKGBUILD.new    2021-06-10 16:25:12.910690819 -0500
@@ -23,11 +23,15 @@

 build() {
     cd "${srcdir}/${pkgname}"
-    go build bing-wallpaper.go
+    GO111MODULE=on go mod download
+    go mod vendor
+    go build
 }

 package() {
     build_dir="${srcdir}/${pkgname}"
-    install -Dm755 "${build_dir}/bing-wallpaper" "${pkgdir}/usr/bin/bing-wallpaper"
+    install -Dm755 "${build_dir}/linux-bing-wallpaper" "${pkgdir}/usr/bin/linux-bing-wallpaper"
     install -Dm644 "${build_dir}/bing-wallpaper.service" "${pkgdir}/usr/lib/systemd/user/bing-wallpaper.service"
+    install -Dm644 "${build_dir}/README.md" "${pkgdir}/usr/share/doc//bing-wallpaper/README.md"
+    install -Dm644 "${build_dir}/config.yaml" "${pkgdir}/usr/share/doc//bing-wallpaper/config.yaml"
 }

Hi, please update the build in PKGBUILD by

GO111MODULE=on go mod download

otherwise some go deps are missing and the package won't build with

Starting build()...
go: github.com/chai2010/gettext-go@v1.0.2: missing go.sum entry; to add it:
    go mod download github.com/chai2010/gettext-go
==> ERROR: A failure occurred in build().

Hi @timxx,

thank you for this nice package! I got an error, is there a dependency on feh missing?

$ systemctl --user status bing-wallpaper.service 
● bing-wallpaper.service - Bing Wallpaper of the Day as your Linux Desktop's wallpaper
     Loaded: loaded (/home/frank/.config/systemd/user/bing-wallpaper.service; enabled; vendor preset: enabled)
     Active: active (running) since Sat 2020-05-09 10:28:34 CEST; 238ms ago
   Main PID: 2926
     CGroup: /user.slice/user-1000.slice/user@1000.service/bing-wallpaper.service

May 09 10:28:34 t530 bing-wallpaper[2926]: panic: fork/exec /usr/bin/feh: no such file or directory
May 09 10:28:34 t530 bing-wallpaper[2926]: goroutine 1 [running]:
May 09 10:28:34 t530 bing-wallpaper[2926]: main.errChk(...)
May 09 10:28:34 t530 bing-wallpaper[2926]:         /home/frank/src/aur/bing-wallpaper-git/src/bing-wallpaper-git/bing-wallpaper.go:28
May 09 10:28:34 t530 bing-wallpaper[2926]: main.setWallpaper(0xc0000161a0, 0x5, 0xc0001a6a80, 0x52, 0x71450a, 0x4)
May 09 10:28:34 t530 bing-wallpaper[2926]:         /home/frank/src/aur/bing-wallpaper-git/src/bing-wallpaper-git/bing-wallpaper.go:339 +0xf17
May 09 10:28:34 t530 bing-wallpaper[2926]: main.main()
May 09 10:28:34 t530 bing-wallpaper[2926]:         /home/frank/src/aur/bing-wallpaper-git/src/bing-wallpaper-git/bing-wallpaper.go:467 +0x8d8
May 09 10:28:34 t530 systemd[1155]: bing-wallpaper.service: Main process exited, code=exited, status=2/INVALIDARGUMENT
May 09 10:28:34 t530 systemd[1155]: bing-wallpaper.service: Failed with result 'exit-code'.

Hi! How can I do for install it on Deepin Desktop? It's impossible for me. Thanks you very much for your help!

Hey,
I've got a few notes concerning your PKGBUILD:

* I'd always use sha512sums, even if the local files are downloaded with the PKGBUILD.

* You are using install for the directories, but not for the files. You can combine this in a single call with proper permissions

* I've always seen PKGBUILDS with ${variables} instead of just $variables. Thats just saver I think.

* I am not sure if the autostart script is needed. But if so, You do not need to cd into the directory where the script is, if i am not totally wrong. And also you should test the connection to microsoft/bing, as it will download from there. If bing is inreachable but google not, this doesnt help. So that all I'd test. And on top of that I suggest to add those scripts to the upstream and not to this PKGBUILD. Open a PR and see if the developer is willing to merge your ideas.

Thank you for taking the time :)

Thank you. This is a nice addition to my laptop.

@serban300
Done! Thanks.

Hello ! Could you add bc as a dependency for the package please ? It seems to be required

@Colibris, I changed the network availability check no more than 3 times. :)

Hello,

This package makes a process that continuously downloads 700 KiB/s.

This may be a problem when someone is on their cellular data, which may happen in the train or, in my case, when I use my phone instead of my university wifi because of bad reception or when I'm unable to use my VPN.

I think you should change it for a regular check every 23 minutes, for example.

I'll upvote your package when you'll have solved this problem.