Package Details: bcwc-pcie-git r242.ea832ac-1

Git Clone URL: https://aur.archlinux.org/bcwc-pcie-git.git (read-only, click to copy)
Package Base: bcwc-pcie-git
Description: Reverse engineered Linux driver for the Broadcom 1570 PCIe webcam.
Upstream URL: https://github.com/patjak/bcwc_pcie
Keywords: driver facetime macbook webcam
Licenses: unknown
Provides: bcwc-pcie, bcwc-pcie-dkms
Replaces: bcwc-pcie, bcwc-pcie-dkms
Submitter: WhyNotHugo
Maintainer: Aetf
Last Packager: Aetf
Votes: 23
Popularity: 0.001337
First Submitted: 2015-12-23 14:14
Last Updated: 2019-12-15 22:46

Latest Comments

1 2 3 4 5 Next › Last »

eschwartz commented on 2019-12-15 22:48

Thanks for the prompt response. :)

Aetf commented on 2019-12-15 22:45

@eschwartz thanks for pointing out the --devel flag. The last time I check it didn't work for some reason. Now it works quite well.

I'm updating all my AUR packages.

Edit: Done ;)

eschwartz commented on 2019-12-15 16:53

@Aetf

Speaking with my official TU hat on, you are required to stop using pkgver=0.0.0, effective immediately, on all AUR packages you maintain.

Users who wish to update AUR VCS-based packages with an AUR helper are expected to use the commonly implemented --devel flag to check VCS packages for updates. Adding an infinitely high pkgver= and relying on the pkgver() function to reset it is NOT acceptable, as this constantly spams users to update even when there is no update available. Furthermore, the pkgrel= is reset to 1 upon the pkgver() function successfully modifying the pkgver=, so it doesn't do anything.

VKen commented on 2019-12-14 02:44

@Aetf: Thanks for the explanation of intended behavior.

Thank you for maintaining the package and I can understand the current setup offloads the maintainer from needing to update the pkgver for every git upstream update.

Indeed there's no rebuild from the output below.

However, it is a matter of my tooling usage and the dissonance compared to my usual experience up to now. The AUR helper usually (with the majority of the small number of git AUR packages I use) will not be flagged for update via yay -Syu.

I will probably need to find a way for myself to configure the AUR helper or augment my usage behavior for: 1. unable to know whether I need to update, since the AUR helper can't tell due to version difference as it overwrites the PKGBUILD with the latest pkgver=0.0.0 to be mismatched from the current installed r242.ea832ac-1. (intended behavior) 2. Although rebuilding is stopped, I need to stop the auto-reinstall if there's no package rebuild. (re-install is probably unintended. A tooling behavior issue to check)

% yay -Syu
...
...
:: 1 Packages to upgrade.
1  aur/bcwc-pcie-git  r242.ea832ac-1 -> 0.0.0-4
==> Packages to exclude: (eg: "1 2 3", "1-3", "^4" or repo name)
==> 
...
...
==> Starting pkgver()...
==> Updated version: bcwc-pcie-git r242.ea832ac-1
==> Sources are ready.
==> Making package: bcwc-pcie-git r242.ea832ac-1 (Sat 14 Dec 2019 10:15:04 AM +08)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> WARNING: Using existing $srcdir/ tree
==> Starting pkgver()...
==> Sources are ready.
==> bcwc-pcie-git-r242.ea832ac-1 already made -- skipping build
==> Found git repo: github.com/patjak/bcwc_pcie.git
loading packages...
warning: bcwc-pcie-git-r242.ea832ac-1 is up to date -- reinstalling
resolving dependencies...
looking for conflicting packages...

Packages (1) bcwc-pcie-git-r242.ea832ac-1

Total Installed Size:  0.16 MiB
Net Upgrade Size:      0.00 MiB

:: Proceed with installation? [Y/n]
...
:: Running pre-transaction hooks...
(1/1) Remove DKMS modules
==> dkms remove bcwc-pcie/r242.ea832ac -k 5.4.2-arch1-1
:: Processing package changes...
(1/1) reinstalling bcwc-pcie-git [###]100%
:: Running post-transaction hooks...
(1/2) Arming ConditionNeedsUpdate...
(2/2) Install DKMS modules
==> dkms install bcwc-pcie/r242.ea832ac -k 5.4.2-arch1-1

Aetf commented on 2019-12-13 02:03

@VKen That's the intended behavior. I deliberately set pkgver=0.0.0 on AUR. So AUR helpers will always remind you to update the package.

For this particular package, the PKGBUILD is unlikely to change in a long time, so the pkgver can get out-of-sync with the latest git version. (In general, I don't think it's useful to update PKGBUILD just to bump the git version)

So this workaround forces AUR helpers to download and check the latest git version. If the latest git version matches what you have locally installed, no package will be built.

VKen commented on 2019-12-13 01:37

@Aetf: The declared version pkgver=0.0.0 does not coincide with the output of:

pkgver() {
  cd "$srcdir/$pkgname"
  printf "r%s.%s" "$(git rev-list --count HEAD)" "$(git rev-parse --short HEAD)"
}

During makepkg the execution modifies PKGBUILD file's declaration of pkgver=0.0.0 to the output of pkgver() == 'r242.ea832ac'.

On my AUR helper "yay", it continually keeps trying to update, rebuild, install, every time I run yay -Syu.

Do you experience this update/install with every run as well?

This package depends on upstream git branch. I've taken a look at other similar git packages like "networkmanager-git"

Their declared pkgver coincides with the output of pkgver(). Their package doesn't trigger the self-update on every invocation of package sync update of the AUR helper.

Aetf commented on 2019-12-10 19:36

@GusevAG it's the same. master is the default branch anyway.

GusevAG commented on 2019-12-10 19:26

@Aetf it works perfectly! before I read your comment, I added #branch=master after the source to the PKGBUILD btw (no idea was it successful or not, but it works)

Aetf commented on 2019-12-10 18:45

@adbjesus thanks for pointing out. I just updated the PKGBUILD to use the master branch.

@GusevAG please try the latest version.

PS. I updated the version number on AUR to always be 0.0.0, making it in line with other git packages I manage on AUR. This way the package will always be shown as updated when using AUR helpers so you can pull the latest changes from the upstream. When building, makepkg will derive the correct version number.

GusevAG commented on 2019-12-10 15:34

@adbjesus wow, that is very important point! thank you for pointing at it! I had no clue about different branches and I have no idea how to change it to master in PKGBUILD could you please give me an example or a picture of what to change exactly and where? I will really appreciate it!

UPD: is it just about changing to

source=("$pkgname::git+https://github.com/patjak/bcwc_pcie.git#branch=master"

?