Arch Linux User Repository

I won't add provides/conflicts for an hypothetical package that does not exist, especially when the authors of bat-extras explicitely recommend using the git master branch instead of a release.

That's logical, no worries.

I guess you have a varying standard regarding useless variables

I never said useless, I said unnecessary. There's no reason to use a custom variable when a predefined one is available.

However, it is of course permissable to prefix custom variables with an underscore as not to conflict with existing or future predefined variables. For more info, see Package etiquette.

I see nothing in the packaging guidelines about removing the '-git' suffix from the package name when installing the LICENSE files.

The name of the project is bat-extras no matter what package extension it has here. Therefore any files and folders should reflect that.

There's a reason the ${pkgname%-*} variable is used throughout the VCS PKGBUILD template instead of $pkgname.

I won't add provides/conflicts for an hypothetical package that does not exist, especially when the authors of bat-extras explicitely recommend using the git master branch instead of a release.

For the variable, this is a matter of coding style, I guess you have a varying standard regarding useless variables (see above).

I see nothing in the packaging guidelines about removing the '-git' suffix from the package name when installing the LICENSE files.

You're missing provides() and conflicts(). If someone should eventually submit a stable version called bat-extras, there would be issues as this package would conflict and Pacman won't know about it.

There's no reason to use unnecessary variables like $_gitname when you can use ${pkgname%-git}. There should be no directories or files installed with the -git extension, that is purely for the PKGBUILD.

See VCS package guidelines and my PKGBUILD for reference.

You missed the bit that removes the leading v from the pkgver, see my comment again. Also see VCS package guidelines.

Git tags are now available:

pkgver() {
    cd "$srcdir/${pkgname%-git}"
    git describe --long --tags | sed 's/^v//;s/\([^-]*-g\)/r\1/;s/-/./g'
}

20190117.r8.765658c

Please add git to makedepends() as well as add provides() and conflicts() arrays.

The license should also be installed.

@yochananmarqos Some users don't/want care about batgrep. Besides, this kind of stuff should be done in check(), so it should be checkdepends but the build script does not support separating building from testing.

...or you could add ripgrep to makedepends() for the check.

This does not build without ripgrep installed:

==> Starting build()...
This will not install the script.
Use --install for a global install.

Preparing scripts...
Building scripts...
    [1/4] /home/yochanan/.cache/yay/bat-extras-git/src/bat-extras/src/batgrep.sh
          Reading...
          Preprocessing...
          Minifying...
          Compressing [skipped]
          Building...
          Installing [skipped]
    [2/4] /home/yochanan/.cache/yay/bat-extras-git/src/bat-extras/src/batman.sh
          Reading...
          Preprocessing...
          Minifying...
          Compressing [skipped]
          Building...
          Installing [skipped]
    [3/4] /home/yochanan/.cache/yay/bat-extras-git/src/bat-extras/src/batwatch.sh
          Reading...
          Preprocessing...
          Minifying...
          Compressing [skipped]
          Building...
          Installing [skipped]
    [4/4] /home/yochanan/.cache/yay/bat-extras-git/src/bat-extras/src/prettybat.sh
          Reading...
          Preprocessing...
          Minifying...
          Compressing [skipped]
          Building...
          Installing [skipped]

Verifying scripts...
Test [batgrep.pattern]: Failed
Test [batgrep.symlink]: Failed
Test [lib.opt]: Passed
RESULT: 1 passed, 2 failed.
==> ERROR: A failure occurred in build().
    Aborting...
Error making: bat-extras-git