Arch Linux User Repository

Hi, I sadly didn't get it working via AUR, but found the corresponding patches here: https://github.com/AppImage/AppImageKit/issues/1084#issuecomment-726358829 Maybe it helps others..

The "mulitple definition of fwriter_buffer" build error described below is caused by a change to GCC's default behavior in GCC 10.0, discussed over on the Gentoo wiki here: https://wiki.gentoo.org/wiki/Gcc_10_porting_notes/fno_common

In the case of this package, the build fails within compiling an external dependency, squashfs-tools. (The code appears to be pretty old, all things considered.) I am supplying a patch that fixes this build error; as I am not a master C programmer you should consider running this by someone else before you use it in production.

This patch is applied in the following directory relative to the top-level PKGBUILD: src/AppImageKit/build/mksquashfs-prefix/src/mksquashfs

The build is still broken due to CMake pulling in mksquashfs on each build but this patch will fix the build error.

diff --git a/squashfs-tools/mksquashfs.c b/squashfs-tools/mksquashfs.c
index a45b77f..4dd16db 100644
--- a/squashfs-tools/mksquashfs.c
+++ b/squashfs-tools/mksquashfs.c
@@ -259,7 +259,7 @@ unsigned int uid_count = 0, guid_count = 0;
 unsigned int sid_count = 0, suid_count = 0, sguid_count = 0;

 struct cache *reader_buffer, *fragment_buffer, *reserve_cache;
-struct cache *bwriter_buffer, *fwriter_buffer;
+extern struct cache *bwriter_buffer, *fwriter_buffer;
 struct queue *to_reader, *to_deflate, *to_writer, *from_writer,
    *to_frag, *locked_fragment, *to_process_frag;
 struct seq_queue *to_main;
diff --git a/squashfs-tools/mksquashfs.h b/squashfs-tools/mksquashfs.h
index 1beefef..b650306 100644
--- a/squashfs-tools/mksquashfs.h
+++ b/squashfs-tools/mksquashfs.h
@@ -143,7 +143,7 @@ struct append_file {
 #endif

 extern struct cache *reader_buffer, *fragment_buffer, *reserve_cache;
-struct cache *bwriter_buffer, *fwriter_buffer;
+extern struct cache *bwriter_buffer, *fwriter_buffer;
 extern struct queue *to_reader, *to_deflate, *to_writer, *from_writer,
    *to_frag, *locked_fragment, *to_process_frag;
 extern struct append_file **file_mapping;

Hi, I leave this package to be maintained by anyone who is interested. if you need the software, you can use an appimage from official releases.

Hopefully somebody else will take up maintaining this, it is a very useful tool.

The exact same output of errors as the two comments below me.

Same here, fails to build. A bunch of multiple definition mksquashfs errors.

I tried installing this today, and I got a build error when it got to mksquashfs

build error log here: https://pastebin.com/bGayHMKu

it's basically lots of this:

multiple definition of fwriter_buffer'; mksquashfs.o:(.bss+0x400c90): first defined here multiple definition ofbwriter_buffer'; mksquashfs.o:(.bss+0x400c98): first defined here

cmake config problems?

Upstream URL should be https://github.com/AppImage/AppImageKit

It's not needed to have a patch anymore to fix the build, so I removed it.

I'm getting the following errors: ==> Starting prepare()... patching file cmake/dependencies.cmake Hunk #1 FAILED at 54. 1 out of 1 hunk FAILED -- saving rejects to file cmake/dependencies.cmake.rej patching file src/mksquashfs-build-fix.patch ==> ERROR: A failure occurred in prepare(). Aborting...